[Due for payment 2025-08-13] Remove call to `getReportNameValuePairs()` in method `getMoneyRequestOptions` from `ReportUtils.ts`

[tgolen]

This is part of #59961 and will ensure that the function is a pure function.

No proposals are necessary for this.

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

I am happy to take it if it is available

[DylanDylann]

🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon

The function getMoneyRequestOptions() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.

✅ Your Task

1. Verify that a unit test exists for getMoneyRequestOptions() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.

2. Refactor getMoneyRequestOptions() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where getMoneyRequestOptions() is called to accommodate the new isReportArchived parameter.

⚠️ Best Practices to Follow

1. Avoid adding new global references to data via Onyx.connect.
2. Avoid using isArchivedReport(nameValuePairs) unless absolutely necessary.
3. Prefer fetching data in a UI component, then pass it down via parameters.
4. Consider using the useReportIsArchived() React hook — it’s designed for this.
5. Before making changes, check if the report's NVPs are already available or if isReportArchived is already calculated or passed.

[lorretheboy]

@DylanDylann I've read and I confirm about requirements. If any chances that I could take this, please assign to me. Thanks

[DylanDylann]

It looks like you haven’t contributed to our codebase yet. While this issue isn’t restricted to experienced contributors, we haven’t seen any activity from you, so there’s nothing to evaluate your work on. To help us get familiar with your work, could you start by tackling some external issues and come back later? Thanks!