[Due for payment 2025-08-13] Remove `Onyx.connect()` for the key: `ONYXKEYS.NVP_LAST_PAYMENT_METHOD` in `src/libs/actions/Search.ts`

[tgolen]

This is part of deprecating Onyx.connect. Parent Issue

Details

• Module: src/libs/actions/Search.ts
• Onyx Key: ONYXKEYS.NVP_LAST_PAYMENT_METHOD
• Reference: Line 31: ONYXKEYS.NVP_LAST_PAYMENT_METHOD

Be sure to refactor methods using test driven development:

1. Create a unit test for methods before refactoring
2. Refactor the methods
3. Ensure the unit test still runs after refactoring
4. Reinforce the unit testing with a functional test and a QA test
5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Issue Owner

Current Issue Owner: @sakluger

[tgolen]

Warning

DO NOT POST PROPOSALS ON THIS ISSUE!!

Bug-Zero Instructions

• This issue is CLOSED for proposals
• It is a special issue and part of a bigger project
• A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
• The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
• There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@tgolen Does this open for contributors?

[tgolen]

Not at this point, no. Depending on how the project goes, we might open them up at some point.

…

On Mon, Jul 28, 2025 at 10:14 AM nkdengineer ***@***.***> wrote: *nkdengineer* left a comment (Expensify/App#67268) <#67268 (comment)> @tgolen <https://github.com/tgolen> Does this open for contributors? — Reply to this email directly, view it on GitHub <#67268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB6Z67VXG4V6N5O7TQT3KZD5RAVCNFSM6AAAAACCRMACY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMRXHE3TSMBZGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sakluger]

@tgolen should this issue be Monthly like the others?

[allgandalf]

@tgolen can you please assign me and @DylanDylann as C+ for this issue.

PR is here:

• Refactor function in Search.ts to remove usage of Onyx.Connect #67205

I will open it up once we have the C+ assigned for correct assignment