Remove `Onyx.connect()` for the key: `ONYXKEYS.COLLECTION.REPORT` in `src/libs/actions/Transaction.ts`

[danieldoglas]

This is part of deprecating Onyx.connect. Parent Issue

Details

• Module: src/libs/actions/Transaction.ts
• Onyx Key: ONYXKEYS.COLLECTION.REPORT
• Reference: Line 73: ONYXKEYS.COLLECTION.REPORT

Be sure to refactor methods using test driven development:

1. Create a unit test for methods before refactoring
2. Refactor the methods
3. Ensure the unit test still runs after refactoring
4. Reinforce the unit testing with a functional test and a QA test
5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

Issue Owner

Current Issue Owner: @dariusz-biela

[danieldoglas]

Warning

DO NOT POST PROPOSALS ON THIS ISSUE!!

Bug-Zero Instructions

• This issue is CLOSED for proposals
• It is a special issue and part of a bigger project
• A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
• The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
• There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[allgandalf]

@tgolen can you please assign me and @DylanDylann here, thanks !

[dariusz-biela]

Hi. I'm Dariusz Biela from Software Mansion.

Gandalf wrote to me that I can take over some of his issues from the "Deprecate Onyx.connect" project from the files:

• src/libs/actions/App.ts
• src/libs/actions/Policy/Tag.ts
• src/libs/migrations/KeyReportActionsDraftByReportActionID.ts
• src/libs/actions/Transaction.ts

@tgolen
Could you assign me to this issue?