[Due for payment 2025-09-09] [$250] Desktop - Cannot close Testdrive after workspace deletion following onboarding

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #67746
Email or phone of affected tester (no customers): new gmail account without +
Issue reported by: Applause Internal Team
Device used: Desktop
App Component: Other

Action Performed:

1. Open the app
2. Log in with a new Gmail account.
3. Click Skip on work email step.
4. Select Manage my team's expenses.
5. Select 1-10 employees > Continue.
6. Select QBO > Continue.
7. Click Continue.
8. After completing the onboarding, delete the workspace.
9. Open FAB > Take a 2-minute test drive.
10. Click Get Started

Expected Result:

Test-drive should close. App should open.

Actual Result:

Test-drive is not closed. User is unable to go to App unless kills the app.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6909803_1754518803247.3_13_PM_2025-08-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021953530588149135434
• Upwork Job ID: 1953530588149135434
• Last Price Increase: 2025-08-14

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Cannot close Testdrive after workspace deletion following onboarding

What is the root cause of that problem?

This only happens when we open Test drive from the Overview page. The reason for this behavior is that TopBar has the data-drag-area attribute:

App/src/components/Navigation/TopBar.tsx

Lines 37 to 39 in d759fda

	<View
	style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.ml5, styles.mr3, styles.headerBarHeight]}
	dataSet={{dragArea: true}}

Through which we set styles

App/web/index.html

Lines 49 to 51 in d759fda

	[data-drag-area='true'] {
	-webkit-app-region: drag;
	}

Although our window opens on top of this page, because TabBar has this style, nothing can be clicked in this part, as it is the part for moving the window

What changes do you think we should make in order to solve the problem?

We can add a style (possibly only for Desktop) that will remove this behavior for this element:

-webkit-app-region: no-drag;

To do that we can pass it here(Or any other part, we can discuss it):

App/src/components/TestDrive/TestDriveBanner.tsx

Lines 15 to 21 in daeff95

	function TestDriveBanner({onPress}: TestDriveBannerProps) {
	const styles = useThemeStyles();
	const {shouldUseNarrowLayout} = useResponsiveLayout();
	const {translate} = useLocalize();
	return (
	<View style={styles.highlightBG}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

If this date attribute is no longer needed, we can remove it.

App/src/components/Navigation/TopBar.tsx

Lines 37 to 39 in d759fda

	<View
	style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.ml5, styles.mr3, styles.headerBarHeight]}
	dataSet={{dragArea: true}}

Or we can pass it as false if testDriveModal is oppened
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021953530588149135434

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't press the Get started button of the test drive.

What is the root cause of that problem?

On desktop app, we have a data-drag-area attribute that marks an element as dragable, and we set this for the WS list page header.

App/src/components/Navigation/TopBar.tsx

Lines 37 to 40 in 0754dfc

	<View
	style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.ml5, styles.mr3, styles.headerBarHeight]}
	dataSet={{dragArea: true}}
	>

This only happens in the WS list because the Get started button happens to be within the dragable area, while on the report screen (Home), the button is within a dragable area too, but above a pressable, and we set it to no drag for pressable inside a dragable area.

App/web/index.html

Lines 52 to 55 in 0754dfc

	[data-drag-area='false'], [data-drag-area='true'] [data-tag="pressable"] {
	-webkit-app-region: no-drag;
	}

In our case, the Get started button is not a child of a dragable area.

What changes do you think we should make in order to solve the problem?

We can change the selector by targeting all pressable elements to make it non-draggable. The downside is that it will add the data-drag-area to pressable, even the ones that don't need it, which most of the pressables don't need.

[data-drag-area='false'], [data-tag="pressable"] {
    -webkit-app-region: no-drag;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@allroundexperts Huh... This is 4 days overdue. Who can take care of this?