[Due for payment 2025-09-04] [$250] Android - Workspace - Default currency of WS shows USD for the first WS regardless of the country

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.93-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176929/test-cases/41237687
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy s10/ Android 12
App Component: Other

Action Performed:

Precondition: Connect to the any country except USD currency based country on your VPN service (Can be New Zealand,
Australia, United Kingdom or the European Union)

Steps

1. Open Hybrid app
2. Navigate to the login page
3. Sign up with a new account
4. On the onboarding, select any option that will keep you in New Expensify (e.g, Manage my team's expenses > 1-10 option)
5. Navigate to Account > Subscription
6. Note the subscription prices are shown in UK
7. Navigate to the existing WS > Overview
8. Note the default currency
9. Create new WS and note the Default currency

Expected Result:

Step 8 and 9 currency should be the same as the account open with the different country.( web behavior)

Actual Result:

The first WS created during onboarding shows USD as default currency

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021955556878114240294
• Upwork Job ID: 1955556878114240294
• Last Price Increase: 2025-08-13
• Automatic offers:
• nkdengineer | Contributor | 108429795

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Default currency of WS shows USD for the first WS regardless of the country

What is the root cause of that problem?

We don't pass local currency as currency for WS

App/src/libs/actions/Policy/Policy.ts

Line 1804 in 2d28c10

const currency = reportCurrency || (allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD);

App/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

Line 185 in 674c981

currency: '',

What changes do you think we should make in order to solve the problem?

Use the provided currency if it's not empty, otherwise fall back to user's local currency or USD

    const currency = (reportCurrency && reportCurrency.trim() !== '') ? reportCurrency : (allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD);

App/src/libs/actions/Policy/Policy.ts

Line 1804 in 2d28c10

const currency = reportCurrency || (allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD);

Update to pass local currency code here (Optional to fall back to USD)

                  currency: currentUserPersonalDetails?.localCurrencyCode ?? CONST.CURRENCY.USD,

App/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

Line 185 in 674c981

currency: '',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first WS created during onboarding shows USD as default currency

What is the root cause of that problem?

After onboarding flow, we have the logic to create the workspace

App/src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

Line 179 in 8dcc9d3

? createWorkspace({

and we're getting the currency from allPersonalDetails and sessionAccountID by using onyx.connect

App/src/libs/actions/Policy/Policy.ts

Line 1815 in 8dcc9d3

const currency = reportCurrency || (allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD);

but these data can be loaded only the file is loaded, so at the time we trigger createWorkspace, these data is undefined so USD is used as the fallback currency

What changes do you think we should make in order to solve the problem?

We shouldn't lean on the data from onyx.connect.

1. In BaseOnboardingInterestedFeatures, get allPersonalDetails and sessionID from useOnyx, get the correct personalDetail then pass it to createWorkspace

createWorkspace(
...
personalDetail: allPersonalDetails?.[session?.accountID],

2. Update buildOptimisticDistanceRateCustomUnits to accept personalDetail

function buildOptimisticDistanceRateCustomUnits(reportCurrency?: string, personalDetail?: PersonalDetails): OptimisticCustomUnits {
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- Disabling this line for safeness as nullish coalescing works only if the value is undefined or null
    const currency = reportCurrency || (personalDetail?.localCurrencyCode ?? allPersonalDetails?.[sessionAccountID]?.localCurrencyCode ?? CONST.CURRENCY.USD);

We can consider to remove the usage of allPersonalDetails and sessionAccountID, and make personalDetail required in this function

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update buildOptimisticDistanceRateCustomUnits to accept personalDetail

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[JmillsExpensify]

Opening up to the community

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021955556878114240294

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[Ahmedklai]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.