[Due for payment 2025-09-12] [$250] LHN - Archived chat with violation doesn't drop to bottom

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.95-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #68005
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Android 12, Win 11, MacOS 10.15.7
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Create new workspace
2. Add two equal expenses
3. Delete workspace

Expected Result:

Archived chat dropped to the LHN bottom, after Pinned, RBR chats, Regular chats and Draft chats.

Actual Result:

Archived chat stays between RBR and Drafts chats

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6917784_1755245738734.Screen_Recording_2025-08-15_at_11.06.57.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021956424513341767970
• Upwork Job ID: 1956424513341767970
• Last Price Increase: 2025-08-15

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Archived chat stays between RBR and Drafts chats

What is the root cause of that problem?

Since reports with errors are categorized before archived reports:

App/src/libs/SidebarUtils.ts

Lines 367 to 377 in 36c8f8b

	if (isPinned || (reportID && reportAttributes?.[reportID]?.requiresAttention)) {
	pinnedAndGBRReports.push(miniReport);
	} else if (hasErrors) {
	errorReports.push(miniReport);
	} else if (hasDraft) {
	draftReports.push(miniReport);
	} else if (isArchivedNonExpenseReport(report, !!rNVPs?.private_isArchived)) {
	archivedReports.push(miniReport);
	} else {
	nonArchivedReports.push(miniReport);
	}

What changes do you think we should make in order to solve the problem?

We should move the isArchivedNonExpenseReport condition above hasErrors:

App/src/libs/SidebarUtils.ts

Lines 367 to 377 in 36c8f8b

	if (isPinned || (reportID && reportAttributes?.[reportID]?.requiresAttention)) {
	pinnedAndGBRReports.push(miniReport);
	} else if (hasErrors) {
	errorReports.push(miniReport);
	} else if (hasDraft) {
	draftReports.push(miniReport);
	} else if (isArchivedNonExpenseReport(report, !!rNVPs?.private_isArchived)) {
	archivedReports.push(miniReport);
	} else {
	nonArchivedReports.push(miniReport);
	}

Note: isArchivedNonExpenseReport can be placed above GBRReports if needed—just below isPinned.
However, for reports that only contain GBR, once the workspace is deleted, all necessary actions on that report are also removed, so it's not really necessary.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test for categorizeReportsForLHN.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021956424513341767970

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-15 19:27:11 UTC.

Not duplicated, my proposal is different with the above proposal

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Archived chat with violation doesn't drop to bottom

What is the root cause of that problem?

When a workspace is deleted, the archived policy expense chat might still have errors (like failed receipt processing). The original categorization order was:

• Pinned/GBR
• hasErrors ← Problem: This caught archived reports with errors - which we should ignore for this case as it is archived
• hasDraft
• isArchivedNonExpenseReport
• nonArchivedReports
  So archived policy expense chats with errors were being categorized as error reports instead of archived reports, causing them to appear between RBR and Drafts instead of at the bottom.
  

  App/src/libs/SidebarUtils.ts

  Lines 367 to 377 in e037dce

  	if (isPinned || (reportID && reportAttributes?.[reportID]?.requiresAttention)) {
  	pinnedAndGBRReports.push(miniReport);
  	} else if (hasErrors) {
  	errorReports.push(miniReport);
  	} else if (hasDraft) {
  	draftReports.push(miniReport);
  	} else if (isArchivedNonExpenseReport(report, !!rNVPs?.private_isArchived)) {
  	archivedReports.push(miniReport);
  	} else {
  	nonArchivedReports.push(miniReport);
  	}

What changes do you think we should make in order to solve the problem?

Archived reports should always be archived, regardless of other states. We should not have error for archived report

const isArchived = isArchivedNonExpenseReport(report, !!rNVPs?.private_isArchived);
const hasErrors = !!report.hasErrorsOtherThanFailedReceipt && !isArchived;

Then replace this condition by isArchived above (Optional to reduce duplicated code)

App/src/libs/SidebarUtils.ts

Line 373 in e037dce

} else if (isArchivedNonExpenseReport(report, !!rNVPs?.private_isArchived)) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We may need to add tests to categorizeReportsForLHN and SidebarOrderTest

What alternative solutions did you explore? (Optional)

NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @lorretheboy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[suneox]

Thanks for all the proposals. I'll take a look at this one tomorrow