[Due for payment 2025-09-09][$250] Attachment - Sharing image with new user shows “chat report” header and error message in chat

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.97-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-352/folder/13176721/41236969/849028040
Email or phone of affected tester (no customers): Slottwo1 2@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Chat Report View

Action Performed:

1. From phone gallary share an image with expensify app
2. Enter a new user
3. Tap share

Expected Result:

Sharing image with new user must show email id in header and image must be shared without any error.

Actual Result:

Sharing image with new user shows chat report in header and error "you doesn't have access to chat room" is shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021958189428754396217
• Upwork Job ID: 1958189428754396217
• Last Price Increase: 2025-08-20
• Automatic offers:
• mkzie2 | Contributor | 108503270

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sharing image with new user shows chat report in header and error "you doesn't have access to chat room" is shown.

What is the root cause of that problem?

We only update the participantsList to add the unknownUserDetails if option.text is empty. But in our case, it's not empty, then the participant is wrong

App/src/libs/OptionsListUtils.ts

Lines 1095 to 1105 in 4d7d44a

	} else if (unknownUserDetails && !option.text) {
	option.text = unknownUserDetails.text ?? unknownUserDetails.login;
	option.alternateText = unknownUserDetails.login;
	option.participantsList = [{...unknownUserDetails, displayName: unknownUserDetails.login, accountID: unknownUserDetails.accountID ?? CONST.DEFAULT_NUMBER_ID}];
	} else if (report?.ownerAccountID !== 0 || !option.text) {
	option.text = getPolicyName({report});
	option.alternateText = translateLocal('workspace.common.workspace');
	}
	option.isDisabled = true;
	option.selected = false;
	option.isSelected = false;

This leads to the created report being invalid because the participant is wrong, and the attachment failed to be added to this report.

App/src/pages/Share/ShareDetailsPage.tsx

Lines 110 to 116 in 4d7d44a

	if (isDraft) {
	openReport(
	report.reportID,
	'',
	displayReport.participantsList?.filter((u) => u.accountID !== currentUserID).map((u) => u.login ?? '') ?? [],
	report,
	undefined,

What changes do you think we should make in order to solve the problem?

We should remove !option.text here since the unknownUserDetails only exists when we don't have a chat with this user. Or we can check the report is draft or not instead of checking !option.text

 } else if (unknownUserDetails) {
// else if (unknownUserDetails && isDraftReport(report?.reportID)) {

App/src/libs/OptionsListUtils.ts

Lines 1095 to 1105 in 4d7d44a

	} else if (unknownUserDetails && !option.text) {
	option.text = unknownUserDetails.text ?? unknownUserDetails.login;
	option.alternateText = unknownUserDetails.login;
	option.participantsList = [{...unknownUserDetails, displayName: unknownUserDetails.login, accountID: unknownUserDetails.accountID ?? CONST.DEFAULT_NUMBER_ID}];
	} else if (report?.ownerAccountID !== 0 || !option.text) {
	option.text = getPolicyName({report});
	option.alternateText = translateLocal('workspace.common.workspace');
	}
	option.isDisabled = true;
	option.selected = false;
	option.isSelected = false;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rohit9625]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sharing image with new user shows chat report in header and error "you doesn't have access to chat room" is shown.

What is the root cause of that problem?

When we select a new user (who doesn't have an Expensify account) at ShareTab while sharing an image, the app saves it as an unknown user and navigates to ShareDetailsPage:

App/src/pages/Share/ShareTab.tsx

Lines 98 to 104 in 4d7d44a

	saveUnknownUserDetails(item);
	const optimisticReport = getOptimisticChatReport(accountID);
	reportID = optimisticReport.reportID;
	saveReportDraft(reportID, optimisticReport).then(() => {
	Navigation.navigate(ROUTES.SHARE_DETAILS.getRoute(reportID.toString()));
	});

At ShareDetailsPage, we see Chat Report at the top, which we show here from displayReport:

App/src/pages/Share/ShareDetailsPage.tsx

Lines 157 to 160 in 4d7d44a

	<UserListItem
	item={displayReport}
	isFocused={false}
	showTooltip={false}

We correctly pass unknownUserDetails to the getReportDisplayOption function to get the displayReport. However, this condition should pass to include text, alternativeText, etc., when we are sharing image with a new user:

App/src/libs/OptionsListUtils.ts

Lines 1095 to 1099 in 4d7d44a

	} else if (unknownUserDetails && !option.text) {
	option.text = unknownUserDetails.text ?? unknownUserDetails.login;
	option.alternateText = unknownUserDetails.login;
	option.participantsList = [{...unknownUserDetails, displayName: unknownUserDetails.login, accountID: unknownUserDetails.accountID ?? CONST.DEFAULT_NUMBER_ID}];
	} else if (report?.ownerAccountID !== 0 || !option.text) {

But it fails because option.text was Chat Report in our case. This is calculated inside the createOption function. Here, getDisplayNameForParticipant and formatPhoneNumber functions return empty strings, so it falls to the getReportName function.

App/src/libs/OptionsListUtils.ts

Lines 999 to 1001 in 4d7d44a

	reportName = showPersonalDetails
	? getDisplayNameForParticipant({accountID: accountIDs.at(0)}) || formatPhoneNumber(personalDetail?.login ?? '')
	: getReportName(report, undefined, undefined, undefined, undefined, undefined, transactions);

The getReportName function further calls getReportNameInternal, where we return report.reportName, i.e., Chat Report in our case, as the last resort:

App/src/libs/ReportUtils.ts

Lines 5434 to 5436 in 4d7d44a

	const finalName = formattedName || (report?.reportName ?? '');
	return isArchivedNonExpense ? generateArchivedReportName(finalName) : finalName;

Hence, option is directly returned without modifying text, alternativeText, etc., according to unknownUserDetails:

App/src/libs/OptionsListUtils.ts

Line 1107 in 4d7d44a

return option;

And this also causes an error in the chat after sending an image because we never get the correct information about the unknown user(new user)

What changes do you think we should make in order to solve the problem?

We should get rid of !option.text in this condition, so that correct information about unknownUser can be included in the option data:

-    } else if (unknownUserDetails && !option.text) {
+    } else if (unknownUserDetails) {

Results:

Screen.Recording.2025-08-20.at.2.42.33.PM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can create a test for the getReportDisplayOption function at the OptionsListUtilsTes.tsx file, including cases like we currently have:

• Should correctly return text and other information when we pass unknownUserDetails to getReportDisplayOption

We can consider multiple cases based on the conditions and data we expect to return from that function. It will help prevent issues in the future.

What alternative solutions did you explore? (Optional)

Alternatively, we can handle it at a higher level, i.e., at the getReportName function by using canUseDerivedValue. When calling getReportName from the createOption function, we are passing almost every important prop as undefined:

App/src/libs/OptionsListUtils.ts

Line 1001 in 4d7d44a

: getReportName(report, undefined, undefined, undefined, undefined, undefined, transactions);

And here we intend to return derivedNames if they exist, and because canUseDerivedValue is true in our case:

App/src/libs/ReportUtils.ts

Lines 5127 to 5133 in 4d7d44a

	// Check if we can use report name in derived values - only when we have report but no other params
	const canUseDerivedValue = report && policy === undefined && parentReportActionParam === undefined && personalDetails === undefined && invoiceReceiverPolicy === undefined;
	const attributes = reportAttributes ?? reportAttributesDerivedValue;
	const derivedNameExists = report && !!attributes?.[report.reportID]?.reportName;
	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}

So, we can add another condition to return '' when we have a report but no other params, i.e., canUseDerivedValue is true and derivedNames doesn't exists:

    if (canUseDerivedValue && derivedNameExists) {
            return attributes[report.reportID].reportName;
+    } else if(canUseDerivedValue) {
+      return '';
+   }

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021958189428754396217

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

Thank you for your proposals!

I think we should go with @mkzie2 's proposal. Their proposal was the first to point out the root cause - the participantsList of the new chat isn’t calculated correctly, which results in an invalid header and an error message.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.