[No payment / project work] [Change Approver] Incorrect error message & system message remains after dismissing error

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #66899
Email or phone of affected tester (no customers): sdjiosdnjdsoidjds111@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Admin invites User A and User B to the workspace.
• Create a new approval workflow where User A submits to User B (approver).

1. Go to staging.new.expensify.com
2. [User A] Go to workspace chat.
3. [User A] Create an expense in the workspace chat and click Submit on the expense preview.
4. [Admin] Open workspace chat with User A.
5. [Admin] Open the expense report.
6. [Admin] Go offline.
7. [Admin] Click More > Change approver.
8. [Admin] Click Bypass approvers, then click Change approver.
9. [Approver] While online, approve the report submitted by User A.
10. [Admin] Go online.
11. [Admin] Dismiss "Auth ChangeApprover returned an error".

Expected Result:

• The error message should be "Unexpected error. Please try again later".
• After dismissing the error, the system message "changed the approver to" should also dismiss.

Actual Result:

• The error message is "Auth ChangeApprover returned an error".
• After dismissing the error, the system message "changed the approver to" does not dismiss. When the system message is opened in thread, the report grays out with missing composer.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[vincdargento]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.