[Due for payment 2025-09-16] Expensify Card - Set a Limit field is not auto-focused

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-442/folder/13176890/41237378/861421216
Email or phone of affected tester (no customers): applausetester+bm846@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

Precondition -

• Expensify card is enabled
• User has set a fully verified Bank account

1. Go to https://staging.new.expensify.com/
2. Go to Expensify Card > Issue Card > finish the flow until Set a Limit field

Expected Result:

Set a Limit field should be automatically focused.

Actual Result:

Set a Limit field is not auto-focused.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - Set a Limit field is not auto-focused

What is the root cause of that problem?

The issue is that AmountForm receives a forwardedRef prop instead of being wrapped with forwardRef.

When InputWrapper tried to pass a ref to AmountForm, it wasn't properly forwarded because:

• React expects components that receive refs to be wrapped with forwardRef
• The ref was passed as a prop named forwardedRef instead of the standard ref

Then useAutoFocusInput Hook never reached the actual text input, so:

• inputRef.current remained null
• inputRef.current?.focus() had no effect

Thus, auto-focus functionality silently failed

App/src/components/AmountForm.tsx

Lines 81 to 88 in 43a7411

	forwardedRef={(ref: BaseTextInputRef | null) => {
	if (typeof forwardedRef === 'function') {
	forwardedRef(ref);
	} else if (forwardedRef && 'current' in forwardedRef) {
	// eslint-disable-next-line no-param-reassign, react-compiler/react-compiler
	forwardedRef.current = ref;
	}
	}}

What changes do you think we should make in order to solve the problem?

Wrap AmountForm with forwardRef

App/src/components/AmountForm.tsx

Line 107 in 43a7411

export default AmountForm;

Update this to forwardedRef={ref}

App/src/components/AmountForm.tsx

Lines 81 to 88 in 43a7411

	forwardedRef={(ref: BaseTextInputRef | null) => {
	if (typeof forwardedRef === 'function') {
	forwardedRef(ref);
	} else if (forwardedRef && 'current' in forwardedRef) {
	// eslint-disable-next-line no-param-reassign, react-compiler/react-compiler
	forwardedRef.current = ref;
	}
	}}

Update this with

}: AmountFormProps, ref: ForwardedRef<BaseTextInputRef>) {

App/src/components/AmountForm.tsx

Line 69 in 43a7411

}: AmountFormProps) {

Optional: Can verify and check other similar places such as MoneyRequestAmountInput,... if it has the same situation, we can fix it as well

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.