[Due for payment 2025-09-19] [$250] Dependent tags - Search field is shown in the tag list when there is less than 8 tags

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.99-5
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #69118
Email or phone of affected tester (no customers): sdhusdhbidshius@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Import dependent tags to the workspace using the file attached.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Manual.
4. Enter amount > Next.
5. On confirm page, click Fund > Select Woodbridge : Operations.
6. Click GL > Select 91.
7. Click GL_DEPARTMENT_DESCRIPTION.

Expected Result:

There will be no search field in the tag list when there is less than 8 tags.

Actual Result:

Search field is shown in the tag list when there is less than 8 tags.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Dep_tags.csv

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021960773407717036167
• Upwork Job ID: 1960773407717036167
• Last Price Increase: 2025-08-27

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tag search field incorrectly appears when there are fewer than 8 tags available in the current context.

What is the root cause of that problem?

In multi-level tag systems, the search field shows even when a parent tag (e.g., "Woodbridge") has only 1 child tag, because the component was counting all policy tags instead of contextually filtered tags.

1. getCountOfEnabledTagsOfList(policyTagList.tags) counts ALL tags in the policy, not the tags available in the current selection context
2. Default parameter logic shouldShowTextInput = !!textInputLabel || !!textInputIconLeft overrides explicit props when textInputLabel is passed

What changes do you think we should make in order to solve the problem?

Instead of counting all policy tags, count the tags that are actually available to the user in the current context:

// Before: Counted all policy tags
const policyTagsCount = getCountOfEnabledTagsOfList(policyTagList.tags);

// After: Count filtered/available tags
const availableTagsCount = Array.isArray(enabledTags) ? enabledTags.length : Object.keys(enabledTags).length;

Also, prevent BaseSelectionList default override by conditionally passing textInputLabel:

<SelectionList
    textInputLabel={shouldShowTextInput ? translate('common.search') : undefined}
    // ... other props
/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add new tests to ensure that such scenarios of filtered tags are handled.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dependent tags - Search field is shown in the tag list when there is less than 8 tags

What is the root cause of that problem?

We display search results only if there are more than 8 items:

App/src/components/TagPicker/index.tsx

Lines 66 to 70 in ed4c640

	const policyTagList = getTagList(policyTags, tagListIndex);
	const policyTagsCount = getCountOfEnabledTagsOfList(policyTagList.tags);
	const isTagsCountBelowThreshold = policyTagsCount < CONST.STANDARD_LIST_ITEM_LIMIT;
	const shouldShowTextInput = !isTagsCountBelowThreshold;

But since the tags are dependent, we have a slightly different logic: we display each subsequent tag after “:”. There were 6 tags at the first level, so their length is 6, at the second level there is 1, so the length remains 6, but at the third level their number increases and 6 more are added to each of the previous tags, resulting in 100 tags, but only 1 is displayed.

What changes do you think we should make in order to solve the problem?

We need to obtain the length of the elements that are actually displayed. To do this, we can count all the elements inside the data of each element:

    const tagsLength = sections.reduce((total, section) => total + (section.data?.length ?? 0), 0);

    const isTagsCountBelowThreshold = tagsLength && tagsLength < CONST.STANDARD_LIST_ITEM_LIMIT;

    const shouldShowTextInput = !isTagsCountBelowThreshold;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.