-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Open
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.MonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Description
Part of the Merge Expenses project
Main issue: https://github.com/Expensify/Expensify/issues/496985
Feature Description
When merging two expenses that have tax rates selected, we'll do the following:
- To ensure there are no conflicts between the user selecting a tax rate and a tax amount that doesn’t compute, we’ll only allow users to select ‘tax rate’ in the details to keep.
- Where tax rates for the two expenses differ, allow the user to select the tax rate in the details page.
- Show the resulting tax in the confirm page, applying the tax rate to the selected amount.
This method can still result in some conflicts, but they also exist on Classic:
- The selected tax rate could be invalid based on the workspace the selected report is on.
- The selected tax rate could conflict with category rules for tax rates.
Manual Test Steps
- Create two expenses with different expense amounts and tax rates
- More > Merge
- Select one of the tax rates and an amount in the details selector page
- In the cofirm page, ensure that the rate and amount are used to calculate the resulting tax amount.
Automated Tests
Issue Owner
Current Issue Owner: @dominictbMetadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.MonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Type
Projects
Status
HIGH