Review button appearing in Report + Expense list view on Approved + Done reports (when no action to take)

[heyjennahay]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): finance.jenna@expensicorp.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @heyjennahay
Slack conversation (hyperlinked to channel name): #migrate #product

Action Performed:

Break down in numbered steps

1. Create a new report on a Submit + Approve workspace
2. Add a manually created expense to the report for an amount larger than the receipt you have
3. Manually attach a receipt for a lessor amount to the manually created expense
4. Confirm a warning is added to the expense Amount greater than scanned receipt
5. Submit the expense
6. View the report as the approver and confirm while in the Outstanding state that there is a Review button in the Report preview in the Inbox
7. View the report on the Reports > Reports page and confirm there is a Review button
8. View the expense on the Reports > Expenses page and confirm there is a Review button
9. Approve the expense
10. View the report preview in the Inbox and see what button is presented (Review = bug)
11. View the report on the Reports > Reports page and see what button is presented on the report (Review = bug)
12. View the expense on the Reports > Expenses page and see what button is presented on the expense (Review = bug)
13. Re perform the test steps again on a Submit + Close workspace skipping steps 6-9

Expected Result:

If a report state = Approved or Done + an expense with a violation/warning, then button should = View or Pay (if payments are enabled on the workspace)

Actual Result:

When report state = Approved or Done + an expense with a violation/warning, then button = Review despite there not being anything to review or any action to take

Workaround:

None

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Report IDR00CSVcch8xR Long ID2720482668126605
Submitter = finance.jenna@expensicorp.com
Approver = jenna@expensify.com

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When report state = Approved or Done + an expense with a violation/warning, then button = Review (despite there not being anything to review or any action to take)

What is the root cause of that problem?

If the transaction has any violation, we only show the view button if the user is submitter and not a admin/approver

App/src/libs/SearchUIUtils.ts

Lines 1157 to 1167 in 57c4e99

	if ((isSubmitter || isApprover || isAdmin) && hasVisibleViolationsForReport) {
	if (isSubmitter && !isApprover && !isAdmin && !canReview(report, allViolations, isIOUReportArchived || isChatReportArchived, policy, allReportTransactions)) {
	allActions.push(CONST.SEARCH.ACTION_TYPES.VIEW);
	} else {
	allActions.push(CONST.SEARCH.ACTION_TYPES.REVIEW);
	}
	}
	// Submit/Approve/Pay can only be taken on transactions if the transaction is the only one on the report, otherwise `View` is the only option.
	// If this condition is not met, return early for performance reasons
	if (isTransaction && !transaction?.isFromOneTransactionReport) {
	return allActions.length > 0 ? allActions : [CONST.SEARCH.ACTION_TYPES.VIEW];

What changes do you think we should make in order to solve the problem?

We should always display the view button if canReview returns false since canReview function checked where the user can review the transaction based on the user's role on this report

if (!canReview(report, allViolations, isIOUReportArchived || isChatReportArchived, policy, allReportTransactions)) {
    allActions.push(CONST.SEARCH.ACTION_TYPES.VIEW);
} else {
    allActions.push(CONST.SEARCH.ACTION_TYPES.REVIEW);
}

App/src/libs/SearchUIUtils.ts

Lines 1157 to 1167 in 57c4e99

	if ((isSubmitter || isApprover || isAdmin) && hasVisibleViolationsForReport) {
	if (isSubmitter && !isApprover && !isAdmin && !canReview(report, allViolations, isIOUReportArchived || isChatReportArchived, policy, allReportTransactions)) {
	allActions.push(CONST.SEARCH.ACTION_TYPES.VIEW);
	} else {
	allActions.push(CONST.SEARCH.ACTION_TYPES.REVIEW);
	}
	}
	// Submit/Approve/Pay can only be taken on transactions if the transaction is the only one on the report, otherwise `View` is the only option.
	// If this condition is not met, return early for performance reasons
	if (isTransaction && !transaction?.isFromOneTransactionReport) {
	return allActions.length > 0 ? allActions : [CONST.SEARCH.ACTION_TYPES.VIEW];

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update SearchUIUtils test to verify the view action is returned for the transaction that can't be reviewed.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[heyjennahay]

Closing in favour of #72486 which we think will resolve the issue