[Due for payment 2025-11-19] [$250] Reports - Create report button opens workspace selector when default workspace is expired

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sjdonisjonsidjosij@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Admin account is expired and has not been renewed
• Admin creates a workspace and invites member to the workspace
• The member has the invited workspace as default workspace
• The member account does not have any expense
• Perform the steps as the invited member

1. Go to staging.new.expensify.com
2. Open FAB > Create report
   → Restricted action page opens
3. Go to Reports > Submit
4. Click Create report button on the empty state

Expected Result:

Restricted action page will open

Actual Result:

Workspace selector opens, even when the invited (and expired) workspace is the only workspace

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6977852_1760710230897.14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021980277291655472724
• Upwork Job ID: 1980277291655472724
• Last Price Increase: 2025-10-27
• Automatic offers:
• FitseTLT | Contributor | 109338083

Issue Owner

Current Issue Owner: @Gonals

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Create report button opens workspace selector when default workspace is expired

What is the root cause of that problem?

We are missing the code that check if shouldRestrictUserBillableActions like here

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 507 to 518 in ea72aea

	if (!shouldRestrictUserBillableActions(workspaceIDForReportCreation)) {
	const createdReportID = createNewReport(currentUserPersonalDetails, isASAPSubmitBetaEnabled, hasViolations, workspaceIDForReportCreation);
	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(
	isSearchTopmostFullScreenRoute()
	? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()})
	: ROUTES.REPORT_WITH_ID.getRoute(createdReportID, undefined, undefined, Navigation.getActiveRoute()),
	{forceReplace: isReportInSearch},
	);
	});
	} else {
	Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(workspaceIDForReportCreation));

here

App/src/libs/SearchUIUtils.ts

Lines 1937 to 1946 in ea72aea

	if (workspaceIDForReportCreation && !shouldRestrictUserBillableActions(workspaceIDForReportCreation) && personalDetails) {
	const createdReportID = createNewReport(personalDetails, isASAPSubmitBetaEnabled, hasViolations, workspaceIDForReportCreation);
	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
	});
	return;
	}
	// If the user's default workspace is personal and the user has more than one group workspace, which is paid and has chat enabled, or a chosen workspace is past the grace period, we need to redirect them to the workspace selection screen
	Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());

What changes do you think we should make in order to solve the problem?

We should check shouldRestrictUserBillableActions and navigate ROUTES.RESTRICTED_ACTION like here

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Line 518 in ea72aea

Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(workspaceIDForReportCreation));

We should check for other create Report buttons and do the same

IF needed we can also implement the case where if the workspaceIDForReportCreation is expired but there are other policies to select we are navigating to workspace selection list here

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 501 to 505 in ea72aea

	if (!workspaceIDForReportCreation || (shouldRestrictUserBillableActions(workspaceIDForReportCreation) && groupPoliciesWithChatEnabled.length > 1)) {
	// If we couldn't guess the workspace to create the report, or a guessed workspace is past it's grace period and we have other workspaces to choose from
	Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());
	return;
	}

What alternative solutions did you explore? (Optional)

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create report button opens workspace selector when default workspace is expired

What is the root cause of that problem?

We already check if the policy has shouldRestrictUserBillableActions, but we don't open the restricted action page:

App/src/libs/SearchUIUtils.ts

Lines 1930 to 1936 in 5681000

	if (workspaceIDForReportCreation && !shouldRestrictUserBillableActions(workspaceIDForReportCreation) && personalDetails) {
	const createdReportID = createNewReport(personalDetails, isASAPSubmitBetaEnabled, hasViolations, workspaceIDForReportCreation);
	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
	});
	return;
	}

What changes do you think we should make in order to solve the problem?

Add a check below the above snippet to open restricted action page if user has 1 only group policy and it's restricted:

if (workspaceIDForReportCreation && groupPoliciesWithChatEnabled.length === 1) {
  Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(workspaceIDForReportCreation));
  return;
}

What alternative solutions did you explore? (Optional)

NA

[abbasifaizan70]

Please re-state the problem that we are trying to solve in this issue.

When a member tries to create a report and their only workspace has an expired admin account, the workspace selector screen opens unnecessarily. Since there's only one workspace available, the user has to select it first before being shown the restricted action page. This creates an extra navigation step when the system should directly show the restricted action page.

What is the root cause of that problem?

In FloatingActionButtonAndPopover.tsx (around line 501) and EmptySearchView.tsx (around line 329), the condition for showing the workspace selector is:

if (!workspaceIDForReportCreation || (shouldRestrictUserBillableActions(workspaceIDForReportCreation) && groupPoliciesWithChatEnabled.length > 1))

This condition navigates to the workspace selector whenever workspaceIDForReportCreation is not initially set, regardless of how many workspaces are available. When a user has only one workspace that isn't their active policy, workspaceIDForReportCreation remains undefined at this point, triggering the workspace selector unnecessarily.

What changes do you think we should make in order to solve the problem?

We should update the logic to handle single-workspace scenarios before showing the selector.

Changes needed in both FloatingActionButtonAndPopover.tsx (~line 501) and EmptySearchView.tsx (~line 329):

Replace the current condition:

if (!workspaceIDForReportCreation || (shouldRestrictUserBillableActions(workspaceIDForReportCreation) && groupPoliciesWithChatEnabled.length > 1)) {
    Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());
    return;
}

With:

// If no workspace determined but multiple available, show selector
if (!workspaceIDForReportCreation && groupPoliciesWithChatEnabled.length > 1) {
    Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());
    return;
}

// If no workspace determined but only one available, use it
if (!workspaceIDForReportCreation && groupPoliciesWithChatEnabled.length === 1) {
    workspaceIDForReportCreation = groupPoliciesWithChatEnabled.at(0)?.id;
}

// If workspace is restricted and there are other options, show selector
if (workspaceIDForReportCreation && shouldRestrictUserBillableActions(workspaceIDForReportCreation) && groupPoliciesWithChatEnabled.length > 1) {
    Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());
    return;
}

This ensures that when a user has only one workspace available (even if restricted), the system uses that workspace and directly navigates to the appropriate page (either creating a report or showing the restricted action page), without the unnecessary workspace selector step.

What alternative solutions did you explore?

Alternative 1: Modify the workspace selector page to auto-navigate when only one workspace exists

• Rejected because: This would add logic in the wrong place and still cause an unnecessary render/navigation cycle

Alternative 2: Set workspaceIDForReportCreation earlier in the flow by changing the conditions at lines 489-494

• Rejected because: This would require broader changes to the workspace selection logic and could affect other flows where the active policy check is intentional

Alternative 3: Add the single-workspace check only after both conditions fail

• Rejected because: This wouldn't prevent the workspace selector from opening; it would just be a fallback that doesn't solve the navigation issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021980277291655472724

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)