Skip to content

[Due for payment 2026-01-14] [$250] Allow approvers to edit expenses on draft open reports #75318

@trjExpensify

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.59-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom / @brianlee-expensify
Slack conversation (hyperlinked to channel name): #73373 (comment)

Action Performed:

Pre-requisites:

  • Have a Control Workspace
  • Submission frequency: Manual
  • Workspace members: Owner, UserA, UserB
  • Configure the approval workflow such that userA submits to userB for approval

Steps:

  1. [UserA] create an expense
  2. [UserB] navigate to UserA's workspace chat and click into the expense report preview
  3. Observe none of the fields are editable

Expected Result:

  • The current approver can edit the expense on a draft open report.

Note: In Classic, open "draft" reports weren't traditionally shared with the approver. So it wasn't a consideration. In NewDot however, the open "draft" reports are shared with the submitter's approver, because they are a member of the parent workspace chat. So we shouldn't be restricting the current approver from editing the expenses on a draft open report.

Actual Result:

  • The approver can't edit the expenses on a draft report.

Workaround:

Yes, once the user submits the report, the approver can edit the expenses on the draft report.

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2025-11-17_15-21-52.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991102792940874223
  • Upwork Job ID: 1991102792940874223
  • Last Price Increase: 2025-11-26
Issue OwnerCurrent Issue Owner: @dylanexpensify

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

Status

MEDIUM or LOW

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions