[$250] Expense - Error when splitting expense after changing submission frequency to Instantly

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp #75792
Email or phone of affected tester (no customers): jsodijnsodijodnsjnoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace chat.
4. Create an expense in workspace chat.
5. Click Submit on the expense preview.
6. Go to workspace settings > Workflows.
7. Disable Add approvals and Make or track payments.
8. Change Submission frequency to Instantly.
9. Go back to workspace chat.
10. Open expense report.
11. Click More > Split > Save.

Expected Result:

Expense can be split without issue after changing submission frequency from manually to instantly.

Actual Result:

Error shows up when splitting expense after changing submission frequency from manually to instantly.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022006171565681274344
• Upwork Job ID: 2006171565681274344
• Last Price Increase: 2026-01-07
• Automatic offers:
• mkzie2 | Contributor | 110235685

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error when splitting a submitted expense after changing submission frequency to instant.

What is the root cause of that problem?

The BE error doesn't tell why the error happens, but it looks like the error happens only when the submission frequency is set to Instantly. If I changed it to Manually, then splitting works again. So, it's either a BE bug, or we intentionally disallow splitting an expense in a policy with submission frequency set to Instantly.

What changes do you think we should make in order to solve the problem?

If we don't want to allow the user to split when the submission frequency is set to Instantly, then we can hide the split option by returning false here if the submission frequency is set to Instantly.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 82 to 134 in edb021d

	function isSplitAction(report: OnyxEntry<Report>, reportTransactions: Array<OnyxEntry<Transaction>>, originalTransaction: OnyxEntry<Transaction>, policy?: OnyxEntry<Policy>): boolean {
	if (Number(reportTransactions?.length) !== 1 || !report) {
	return false;
	}
	const reportTransaction = reportTransactions.at(0);
	const isScanning = hasReceiptTransactionUtils(reportTransaction) && isReceiptBeingScanned(reportTransaction);
	if (isPending(reportTransaction) || isScanning || !!reportTransaction?.errors) {
	return false;
	}
	const {amount} = getTransactionDetails(reportTransaction) ?? {};
	if (!amount) {
	return false;
	}
	const {isBillSplit} = getOriginalTransactionWithSplitInfo(reportTransaction, originalTransaction);
	if (isBillSplit) {
	return false;
	}
	if (!isExpenseReportUtils(report)) {
	return false;
	}
	if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {
	return false;
	}
	if (hasOnlyNonReimbursableTransactions(report.reportID) && isSubmitAndClose(policy) && isInstantSubmitEnabled(policy)) {
	return false;
	}
	const isSubmitter = isCurrentUserSubmitter(report);
	const isAdmin = policy?.role === CONST.POLICY.ROLE.ADMIN;
	const isManager = (report.managerID ?? CONST.DEFAULT_NUMBER_ID) === getCurrentUserAccountID();
	const isOpenReport = isOpenReportUtils(report);
	const isPolicyExpenseChat = !!policy?.isPolicyExpenseChatEnabled;
	const currentUserEmail = getCurrentUserEmail();
	const userIsPolicyMember = isPolicyMember(policy, currentUserEmail);
	if (!(userIsPolicyMember && isPolicyExpenseChat)) {
	return false;
	}
	if (isOpenReport) {
	return isSubmitter || isAdmin;
	}
	// Hide split option for the submitter if the report is forwarded
	return (isSubmitter && isAwaitingFirstLevelApproval(report)) || isAdmin || isManager;
	}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022006171565681274344

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)