[Duplicate Expenses] Add Distance Expense Support

[trjExpensify]

Parent issue

---

For release 1 of duplicate expenses, we decided to exclude distance expenses so that we can move the PR along.

Lets make sure we add back distance expense support in this issue.

[jjcoffee]

I guess we sort of aligned on following per diem behaviour when duplicating a distance expense from a non-primary workspace?

@trjExpensify:

My initial thought is why don't we treat this like moving a distance expense from one workspace to another. Insofar as the rate on the expense being duped is kept, but displayed as invalid for the workspace until the user changes it.

@garrettmknight:

I'd prefer follow the 'move workspace' pattern instead, allowing the user to duplicate an expense and either move it to a workspace with a valid rate OR updating the rate in order to remove the violation.

(See the discussion on the PR for reference.)

@JS00001 Would you be implementing the BE changes required for this? Currently duplicating a distance expense from a non-primary workspace will result in a BE error as the rate is invalid (and the expense won't get added at all).

[jjcoffee]

Also @hoangzinh comment here to get assigned 🙏

[hoangzinh]

👋

[jjcoffee]

Draft PR is here.

[jjcoffee]

@JS00001 Regarding the backend changes required:

Prerequisites

• Have two workspaces
• Have distance rates enabled on both, with just the default rate

Action Performed:

1. Create a distance expense on a non-default workspace.
2. Open the expense.
3. Go to More -> Duplicate.
4. Go to the default workspace.
5. Open the duplicated distance expense.

Expected Result:

Adds the expense, with an error that the rate is not valid and needs to be updated. Open for discussion, but it possibly should not show an error if both workspaces just have a default rate (I don't know how feasible this is though).

Actual Result:

Does not add the expense. Has a 666 response code, and an error The selected rate has been deleted.

[JS00001]

Will try and take a look at this, may also post for an external BE contributor