[Due for payment 2026-01-07] [$250] Reports - "Reset Filters" is not displayed on filters page when "Group By" filter is applied

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2402/folder/13176922/41237509/1080011226
Email or phone of affected tester (no customers): ibellicotest+2230@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the staging.new.expensify.com website.
2. Navigate to "Reports" > "Expenses"
3. Tap on "Filters"
4. Open any filter except "Group By" and apply any option.
5. Note that after selected filter is saved, a "Reset Filters" option appears on the top right corner on filters page.
6. Reset the applied filter.
7. Tap on "Group By" and select any option.
8. Tap on "Save"
9. When landing on filters page, note that "Reset Filters" option is not displayed on the top right corner.

Expected Result:

When user applies any advanced filter, a "Reset Filters" option should be visible on the top right corner on filters page.

Actual Result:

When user applies the "Group By" advanced filter, "Reset Filters" option is not visible on the top right corner on filters page.
"Reset Filters" option is visible when any other advanced filter is applied.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022001420075452512496
• Upwork Job ID: 2001420075452512496
• Last Price Increase: 2025-12-17
• Automatic offers:
• etCoderDysto | Contributor | 109860860

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Reset Filters" is not displayed on filters page when "Group By" filter is applied

What is the root cause of that problem?

1. We are returning false when key equals to groupBy when calculating shouldShowResetFilters
   

   App/src/pages/Search/SearchAdvancedFiltersPage.tsx

   Lines 23 to 25 in 617cb22

   	if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) {
   	return false;
   	}

2. When clicking reset filters, we are returning early if key === FILTER_KEYS.GROUP_BY and the button is not functional
   

   App/src/libs/actions/Search.ts

   Lines 968 to 974 in 617cb22

   	function clearAdvancedFilters() {
   	const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {};
   	for (const key of Object.values(FILTER_KEYS)) {
   	switch (key) {
   	case FILTER_KEYS.GROUP_BY:
   	continue;
   	case FILTER_KEYS.COLUMNS:

What changes do you think we should make in order to solve the problem?

1. We should remove the if condition

 if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) {
                return false;
            }

App/src/pages/Search/SearchAdvancedFiltersPage.tsx

Lines 23 to 25 in 617cb22

	if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY) {
	return false;
	}

2. We should remove the below condition for reset filter button to work

case FILTER_KEYS.GROUP_BY:
                continue;

App/src/libs/actions/Search.ts

Line 971 in 617cb22

switch (key) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[etCoderDysto]

This issue is reproducible on production too.