Remove `Onyx.connect()` for the key: `ONYXKEYS.ONYXKEYS.SESSION` in `src/libs/actions/User.ts`

[tgolen]

This is part of deprecating Onyx.connect. Parent Issue

Details

• Module: src/libs/actions/User.ts
• Onyx Key: ONYXKEYS.ONYXKEYS.SESSION
• Reference: Line 67: ONYXKEYS.ONYXKEYS.SESSION

Be sure to refactor methods using test driven development:

1. Create a unit test for methods before refactoring
2. Refactor the methods
3. Ensure the unit test still runs after refactoring
4. Reinforce the unit testing with a functional test and a QA test
5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code

[tgolen]

Warning

DO NOT POST PROPOSALS ON THIS ISSUE!!

Bug-Zero Instructions

• This issue is CLOSED for proposals
• It is a special issue and part of a bigger project
• A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
• The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
• There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[tgolen]

This will be worked on soon