Skip to content

Support partial approval from Reports page #78046

@puneetlath

Description

@puneetlath

In #72486 we removed the Review button and replaced it with direct action buttons from the Reports list and Workspace chat (e.g. submit, approve, pay, etc). However, this doesn't support the partial case where some expenses are held. In that case, we are currently showing the View button instead of the Approve button.

Image

Let's update the Reports page to support partial approval. To do this we will make the following updates when a report has held expenses:

  • Replace the View button with an Approve button
  • Show the modal to ask how much the user wants to approve, the un-held total or all expenses
Image

cc @nkdengineer @eVoloshchak

Issue OwnerCurrent Issue Owner: @nkdengineer

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions