-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Support partial approval from Reports page #78046
Copy link
Copy link
Open
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
In #72486 we removed the Review button and replaced it with direct action buttons from the Reports list and Workspace chat (e.g. submit, approve, pay, etc). However, this doesn't support the partial case where some expenses are held. In that case, we are currently showing the View button instead of the Approve button.
Let's update the Reports page to support partial approval. To do this we will make the following updates when a report has held expenses:
- Replace the
Viewbutton with anApprovebutton - Show the modal to ask how much the user wants to approve, the un-held total or all expenses
Issue Owner
Current Issue Owner: @nkdengineerReactions are currently unavailable
Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Type
Projects
Status
Done