[$250] Marked as paid system message does not appear offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.86-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76711
Email or phone of affected tester (no customers): gocemate+b21549011@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Samsung Galaxy A02s/12
App Component: Chat Report View

Action Performed:

1. Login with new account
2. Tap to the "Reports" tab
3. Go offline
4. Click on "Create expense"
5. Tap on "Manual"
6. Add an amount and tap on "Next"
7. In Choose recipient page, select "Manager McTest"
8. Create and open the expense

Expected Result:

Marked as paid system message should appear.

Actual Result:

Marked as paid system message does not appear offline

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022003639633025621780
• Upwork Job ID: 2003639633025621780
• Last Price Increase: 2025-12-31

Issue Owner

Current Issue Owner: @carlosmiceli

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Marked as paid system message does not appear offline

What is the root cause of that problem?

For the MCTest expense, we create a new IOU action with type is pay to override the existing optimistic iou.action.

App/src/libs/actions/IOU.ts

Lines 1832 to 1850 in 72de675

	if (isMoneyRequestToManagerMcTest) {
	const date = new Date();
	const isTestReceipt = transaction.receipt?.isTestReceipt ?? false;
	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	const optimisticIOUReportAction = buildOptimisticIOUReportAction({
	type: isScanRequest && !isTestReceipt ? CONST.IOU.REPORT_ACTION_TYPE.CREATE : CONST.IOU.REPORT_ACTION_TYPE.PAY,
	amount: iou.report?.total ?? 0,
	currency: iou.report?.currency ?? '',
	comment: '',
	participants: [managerMcTestParticipant],
	paymentType: isScanRequest && !isTestReceipt ? undefined : CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
	iouReportID: iou.report.reportID,
	transactionID: transaction.transactionID,
	reportActionID: iou.action.reportActionID,
	});
	optimisticData.push(
	// @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830
	{

But we still pass the iou.action to merge into snapshot here. Then the paid system message doesn't appear

App/src/libs/actions/IOU.ts

Line 2184 in 72de675

iouAction: iou.action,

What changes do you think we should make in order to solve the problem?

We should pass the iouAction correctly here

let iouAction = iou.action;
if (isMoneyRequestToManagerMcTest) {
...
iouAction = optimisticIOUReportAction;
}

App/src/libs/actions/IOU.ts

Lines 1832 to 1850 in 72de675

	if (isMoneyRequestToManagerMcTest) {
	const date = new Date();
	const isTestReceipt = transaction.receipt?.isTestReceipt ?? false;
	const managerMcTestParticipant = getManagerMcTestParticipant() ?? {};
	const optimisticIOUReportAction = buildOptimisticIOUReportAction({
	type: isScanRequest && !isTestReceipt ? CONST.IOU.REPORT_ACTION_TYPE.CREATE : CONST.IOU.REPORT_ACTION_TYPE.PAY,
	amount: iou.report?.total ?? 0,
	currency: iou.report?.currency ?? '',
	comment: '',
	participants: [managerMcTestParticipant],
	paymentType: isScanRequest && !isTestReceipt ? undefined : CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
	iouReportID: iou.report.reportID,
	transactionID: transaction.transactionID,
	reportActionID: iou.action.reportActionID,
	});
	optimisticData.push(
	// @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830
	{

iouAction: iouAction,

App/src/libs/actions/IOU.ts

Line 2184 in 72de675

iouAction: iou.action,

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Marked as paid system message should appear.

What is the root cause of that problem?

When creating an expense with "Manager McTest" offline:

• The code creates a PAY action with CONST.IOU.PAYMENT_TYPE.ELSEWHERE and adds it to the IOU report's report actions.
• It updates the IOU report's status to MARKED_REIMBURSED.
• It does not add the PAY action to the chat report's report actions.
• The "marked as paid" system message appears in the chat report, which requires the PAY action to be present in the chat report's report actions.

What changes do you think we should make in order to solve the problem?

When isMoneyRequestToManagerMcTest is true and a PAY action is created (not CREATE), the fix:

• Adds the PAY action to the chat report's report actions so it can be displayed as a system message.
• Updates the chat report's lastMessageText and lastMessageHtml to show the "marked as paid" message.
• Updates the chat report's iouReportID to null (since it's been paid).
• Updates the chat report's hasOutstandingChildRequest to false.
• Updates the chat report's lastVisibleActionCreated to the PAY action's created timestamp.

const isPayAction = isScanRequest && !isTestReceipt ? false : true;
        const optimisticIOUReportAction = buildOptimisticIOUReportAction({
            type: isScanRequest && !isTestReceipt ? CONST.IOU.REPORT_ACTION_TYPE.CREATE : CONST.IOU.REPORT_ACTION_TYPE.PAY,
            amount: iou.report?.total ?? 0,
            currency: iou.report?.currency ?? '',
            comment: '',
            participants: [managerMcTestParticipant],
            paymentType: isScanRequest && !isTestReceipt ? undefined : CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
            iouReportID: iou.report.reportID,
            transactionID: transaction.transactionID,
            reportActionID: iou.action.reportActionID,
            isSettlingUp: isPayAction,
        });

if (isPayAction && chat.report) {
            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chat.report.reportID}`,
                value: {
                    [optimisticIOUReportAction.reportActionID]: {
                        ...(optimisticIOUReportAction as OnyxTypes.ReportAction),
                    },
                },
            });
            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${chat.report.reportID}`,
                value: {
                    lastMessageText: getReportActionText(optimisticIOUReportAction),
                    lastMessageHtml: getReportActionHtml(optimisticIOUReportAction),
                    lastVisibleActionCreated: optimisticIOUReportAction.created,
                    iouReportID: null,
                    hasOutstandingChildRequest: false,
                },
            });
        }

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022003639633025621780

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)