[$250] Wallet - Can transfer balance to Non-US bank account

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176725/test-cases/41237085
Email or phone of affected tester (no customers): leungbratt6+p2p@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: User Settings

Action Performed:

Preconditions:
Enable wallet for 2 different users and user B with 2 bank accounts a USD Bank account and a NON-US bank account (set default USD currency)

1. As User A - Pay user B so they have a positive amount in their wallet if needed
2. As User B - Navigate to Wallet and Click “Transfer balance ”
3. Select the bank account "Plaid.xxx1111"
4. Click on the Transfer button
5. Select the NON-US bank account, not the default
6. Click on the Transfer button

Expected Result:

Non-US bank account shouldn't display in the Wallet option to transfer

Actual Result:

When transferring to a US bank account, the balance is still $x.xx, but after transferring to a NON-US bank account, the balance turns to $0.00

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022011611057189095662
• Upwork Job ID: 2011611057189095662
• Last Price Increase: 2026-01-15

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user has both a USD bank account and a NON-US bank account, the wallet transfer balance page incorrectly displays all bank accounts including NON-US accounts. Selecting a NON-US bank account causes the balance to show as $0.00, which is incorrect behavior. Non-US bank accounts should not be available as transfer options.

What is the root cause of that problem?

The root cause is in src/pages/settings/Wallet/ChooseTransferAccountPage.tsx. The bankAccountOptions useMemo displays all bank accounts without filtering for US-only accounts.

However, in src/libs/PaymentUtils.ts#L49-L59, the hasExpensifyPaymentMethod function correctly validates that only US bank accounts are valid for Expensify wallet:

const validBankAccount = Object.values(bankAccountList).some((bankAccountJSON) => {
    const bankAccount = new BankAccountModel(bankAccountJSON);
    return (
        bankAccount.getPendingAction() !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
        bankAccount.isOpen() &&
        bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL &&
        bankAccount?.getCountry() === CONST.COUNTRY.US  // <-- US only filter
    );
});

The ChooseTransferAccountPage.tsx is missing this country filter, allowing NON-US bank accounts to be displayed and selected.

What changes do you think we should make in order to solve the problem?

Filter the bank accounts in ChooseTransferAccountPage.tsx to only show US bank accounts by adding a filter before mapping the options:

// src/pages/settings/Wallet/ChooseTransferAccountPage.tsx
const bankAccountOptions = useMemo(() => {
    const options = Object.values(bankAccountsList ?? {})
        .filter((bankAccount) => {
            // Only show US bank accounts for wallet transfer
            const country = bankAccount.accountData?.additionalData?.country ?? CONST.COUNTRY.US;
            return country === CONST.COUNTRY.US;
        })
        .map((bankAccount, index): BankAccountListItem => {
            // ... existing mapping logic
        });
    return options;
}, [bankAccountsList, selectedAccountID, styles, translate]);

App/src/pages/settings/Wallet/ChooseTransferAccountPage.tsx

Lines 61 to 67 in 232cb11

	const bankAccountOptions = useMemo(() => {
	const options = Object.values(bankAccountsList ?? {}).map((bankAccount, index): BankAccountListItem => {
	const bankName = (bankAccount.accountData?.additionalData?.bankName ?? '') as BankName;
	const bankAccountNumber = bankAccount.accountData?.accountNumber ?? '';
	const bankAccountID = bankAccount.accountData?.bankAccountID ?? bankAccount.methodID;
	const {icon, iconSize, iconStyles} = getBankIcon({bankName, styles});
	return {

What alternative solutions did you explore? (Optional)

[khushi0433]

Hi there!

I’ve reviewed this issue and have a clear fix in mind for filtering non-US bank accounts in the Wallet Transfer page. Below is my proposed solution.

[melvin-bot]

📣 @khushi0433! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[khushi0433]

Proposal:

Problem Statement:
Currently, when a user has both a USD bank account and a non-US bank account, the Wallet Transfer Balance page displays all bank accounts, including non-US accounts. Selecting a non-US bank account results in the balance showing as $0.00, which is incorrect. Only US bank accounts should be available as transfer options.

Root Cause:
The issue originates in src/pages/settings/Wallet/ChooseTransferAccountPage.tsx. The bankAccountOptions useMemo currently displays all bank accounts without filtering for US-only accounts.

In contrast, the function hasExpensifyPaymentMethod in src/libs/PaymentUtils.ts#L49-L59 correctly filters bank accounts to ensure only US accounts are valid for Expensify wallet transfers:

const validBankAccount = Object.values(bankAccountList).some((bankAccountJSON) => {
    const bankAccount = new BankAccountModel(bankAccountJSON);
    return (
        bankAccount.getPendingAction() !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
        bankAccount.isOpen() &&
        bankAccount.getType() === CONST.BANK_ACCOUNT.TYPE.PERSONAL &&
        bankAccount?.getCountry() === CONST.COUNTRY.US
    );
});

ChooseTransferAccountPage.tsx is missing this country check, which allows non-US accounts to appear and be selectable.

Proposed Solution:
Update @ChooseTransferAccountPage.tsx to filter bank accounts and display only US accounts:

const bankAccountOptions = useMemo(() => {
    const options = Object.values(bankAccountsList ?? {})
        .filter((bankAccount) => {
            const country = bankAccount.accountData?.additionalData?.country ?? CONST.COUNTRY.US;
            return country === CONST.COUNTRY.US;
        })
        .map((bankAccount, index): BankAccountListItem => {
            // ... existing mapping logic
        });
    return options;
}, [bankAccountsList, selectedAccountID, styles, translate]);

This ensures the Wallet Transfer page aligns with the expected behavior and existing validation logic.

Alternative Solutions Considered:
Filtering bank accounts at the API/backend level could prevent non-US accounts from being returned. However, applying the filter in the frontend is preferable because:

• It aligns with the existing hasExpensifyPaymentMethod logic.
• The bank account list may be reused elsewhere without this filter.
• It is a minimal and targeted fix that addresses the immediate problem without affecting other parts of the system.

Impact:
After implementing this fix, users will only see valid US bank accounts for wallet transfers, eliminating the $0.00 balance issue and improving the user experience.

[khushi0433]

Contributor details
Your Expensify account email: khushbubaloch01+@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01626b34fb15c459c0

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022011611057189095662