[Onyx Audit] Remove allowDynamicKey from useOnyx

[fabioh8010]

Coming from #71202.

In order to simplify useOnyx API (and consequently Onyx) let's work on proposing the removal of some configurations we think are anti-patterns / unnecessary at this point.

The allowDynamicKey configuration controls whether the key can be changed dynamically during the component lifecycle. This prop is only neccessary for the Search snapshots in E/App's Onyx wrapper, so it's basically one product feature that is "leaking" into Onyx state management library.

We need to explore our Onyx wrapper to see if it’s possible to remove it (do we still need this?), or use an alternative approach.

Issue Owner

Current Issue Owner: @JKobrynski

[mountiny]

We need to explore our Onyx wrapper to see if it’s possible to remove it (do we still need this?), or use an alternative approach.

Would be great to explore this, the snapshot should be changed in future to only point to live data, right @luacmartins (sorry I might be out of date).

[luacmartins]

As of now, the wrapper still needs it to switch back and forth between snapshot/live data. We don't have a project to deprecate the snapshot yet, but I think that'll come soon.

[luacmartins]

We've had a challenging time proposing deprecating the snapshots because of "no perceived user value". I think if we can tie it to some performance improvement, that'd be a good way to propose it. One thing we could try is measuring the Search page performance when:

1. Remove the snapshot code from Onyx
2. Remove useOnyx wrapper in App

[mountiny]

I think if we can tie it to some performance improvement, that'd be a good way to propose it

I would love to do that, you have my 👍 it will certainly help a bit with performance but it will help a lot with making the code cleaner

[fabioh8010]

Nice, I agree this is the right direction if we are able to prove the performance gains

[luacmartins]

OK, so it sounds like the next step here is to create a POC branch removing the snapshot code from Onyx and the Onyx wrapper, then measuring the page performance. Does that sounds right @fabioh8010? If so, are you available to work on that? I think that might be easier once we merge this PR that uses live data for Search to-dos