[$375] After forcekill & reopen app, error message changes when approver leaves workspace

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory around #79910
Email or phone of affected tester (no customers): kiatest.78+ck11226@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 16/iOS 18.7.1, Pixel 8a/Android 16
App Component: Workspace Settings

Action Performed:

Precondition:

1. Owner- Create new workspace
2. Owner - Go to the workflows page, then set user A as the approver of expenses from user B.
3. Member - As user B, submit an expense
   Steps:
4. Launch Hybrid app & login as User A who is approver
5. Go to workspaces list page
6. Click on the three dots menu
7. Choose Leave and confirm
8. Observe the error message shown as - "Please approve any outstanding expense reports submitted to you before leaving the workspace"
9. Tap x icon to close the error message
10. Force kill app & reopen it
11. Repeat steps 2-4
12. Observe different error message displayed - "Something went wrong while leaving the workspace"

Expected Result:

After force kill app ag reopen it, error message should be same as "Please approve any outstanding expense reports submitted to you before leaving the workspace" when approver leaves workspace

Actual Result:

After force kill & reopen app, error message changes when approver leaves workspace. Message changes to "Something went wrong while leaving the workspace"

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7055206_1769053359121.ScreenRecording_01-21-2026_22-41-25_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022018976973815799559
• Upwork Job ID: 2018976973815799559
• Last Price Increase: 2026-04-07

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.

After force killing and reopening the app, the error when an approver tries to leave a workspace changes from a specific message about outstanding expense reports to a generic error, even though the blocking condition remains.

What is the root cause of that problem?

failureData in leaveWorkspace unconditionally sets a generic error in employeeList[email].errors, overwriting server-provided errors from response.onyxData. The server applies its error first, then failureData overwrites it. After app restart, if the server doesn't include the specific error in response.onyxData, only the generic error remains.

What changes do you think we should make in order to solve the problem?

• Remove the errors field from failureData in leaveWorkspace.
• Let server-provided errors in response.onyxData remain unchanged.
• Reset pendingAction to null in the employeeList entry to fully roll back the optimistic update.

Code change

File: src/libs/actions/Policy/Policy.ts
Function: leaveWorkspace

// ... existing code ...
const failureData: Array<
    OnyxUpdate<
        typeof ONYXKEYS.COLLECTION.POLICY |
        typeof ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS |
        typeof ONYXKEYS.COLLECTION.REPORT_METADATA
    >
> = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: {
            pendingAction: policy?.pendingAction ?? null,
            employeeList: {
                [deprecatedSessionEmail]: {
                    pendingAction: null,
                },
            },
        },
    },
];
// ... existing code ...

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022018976973815799559

[JmillsExpensify]

Opened up for proposals

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)