Skip to content

[Domain Control][Release 4] [BE] Add optional domainAccountID param to UpdateDomainSecurityGroup, create an Alias for each setting, and send related Onyx error updates under domainErrors_ #81720

@rayane-d

Description

@rayane-d

Part of #76750

Problem

UpdateDomainSecurityGroup needs to send Onyx error data in the following format in order show the error under the changed setting (under the specific row):

domainErrors_<domainID>.domain_securityGroup_<groupID>.[<settingsName>Errors]

Currently, we don't have logic to send errors under the domainErrors_ Onyx key for the UpdateDomainSecurityGroup endpoint.


Solution

  • Accept an optional domainAccountID parameter in the API endpoint, since this endpoint is also used elsewhere
  • Create an Alias for each security group setting to help us distinguish where to put the errors
  • Add BE logic to send errors under the domainErrors_ Onyx key

Conversation: https://expensify.slack.com/archives/C0A1VKRKEE9/p1768487896486359
Doc section: https://docs.google.com/document/d/13ZgHapzyeDYny155suwlSRQUvdWqE1DkNNDRJ6Pk3i0/edit?tab=t.0#bookmark=id.topbo3undd5b


This is needed by this issue: #80133

Metadata

Metadata

Assignees

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Status

No status

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions