Track - Map preview is not displayed when submit expense to workspace chat via self dm

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.23-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5794/folder/13176877/41237352/1201035509?sort=-status_id
Email or phone of affected tester (no customers): gocemate+b215490617@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Chat Report View

Action Performed:

Precondition: User have a workspace

Steps:

1. Navigate to self-DM chat
2. Create distance track expense
3. Select Submit it to someone from whisper
4. Select Workspace chat and complete the process
5. Wait for few seconds

Expected Result:

Map preview should be displayed

Actual Result:

Map preview disappears when track distance expense from self DM chat is submiited to workspace

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7082839_1771532004166.Recording__239.mp4

View all open jobs on GitHub

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user tracks a distance expense in self-DM and then submits it to a workspace chat via the actionable whisper flow, the map preview appears briefly and then disappears. The expense should keep showing the distance map preview in the destination workspace chat.

What is the root cause of that problem?

The attachment renderer only keeps the distance map UI when there is no receipt source (or when the source is an image). Once the transaction is reconciled and a non-image receipt source is present, the condition no longer renders DistanceEReceipt, so the map preview disappears.

App/src/components/Attachments/AttachmentView/index.tsx

Lines 260 to 265 in 480fd3d

	if (isDistanceRequest(transaction) && !isManualDistanceRequest(transaction) && !isOdometerDistanceRequest(transaction) && transaction) {
	// Distance eReceipts are now generated as a PDF, but to keep it backwards compatible we still show the old eReceipt view for image receipts
	const isImageReceiptSource = checkIsFileImage(source, file?.name);
	if (!hasReceiptSource(transaction) || isImageReceiptSource) {
	return <DistanceEReceipt transaction={transaction} />;
	}

if (isDistanceRequest(transaction) && !isManualDistanceRequest(transaction) && !isOdometerDistanceRequest(transaction) && transaction) {
    // Distance eReceipts are now generated as a PDF, but to keep it backwards compatible we still show the old eReceipt view for image receipts
    const isImageReceiptSource = checkIsFileImage(source, file?.name);
    if (!hasReceiptSource(transaction) || isImageReceiptSource) {
        return <DistanceEReceipt transaction={transaction} />;
    }
}

This behavior is especially visible in tracked-expense conversion flows, where we optimistically force a generic receipt to show map preview first, then server reconciliation updates attachment data.

App/src/libs/actions/IOU/index.ts

Lines 7364 to 7366 in 480fd3d

	// Pass an open receipt so the distance expense will show a map with the route optimistically
	const trackedReceipt = validWaypoints ? {source: ReceiptGeneric as ReceiptSource, state: CONST.IOU.RECEIPT_STATE.OPEN, name: 'receipt-generic.png'} : receipt;
	const sanitizedWaypoints = validWaypoints ? JSON.stringify(sanitizeRecentWaypoints(validWaypoints)) : undefined;

// Pass an open receipt so the distance expense will show a map with the route optimistically
const trackedReceipt = validWaypoints ? {source: ReceiptGeneric as ReceiptSource, state: CONST.IOU.RECEIPT_STATE.OPEN, name: 'receipt-generic.png'} : receipt;
const sanitizedWaypoints = validWaypoints ? JSON.stringify(sanitizeRecentWaypoints(validWaypoints)) : undefined;

What changes do you think we should make in order to solve the problem?

Update AttachmentView so distance requests continue to render DistanceEReceipt regardless of whether the receipt source is image/PDF (as long as it is a non-manual, non-odometer distance transaction). This preserves map preview after reconciliation and aligns with expected behavior for submitted distance expenses.

App/src/components/Attachments/AttachmentView/index.tsx

Lines 260 to 265 in 480fd3d

	if (isDistanceRequest(transaction) && !isManualDistanceRequest(transaction) && !isOdometerDistanceRequest(transaction) && transaction) {
	// Distance eReceipts are now generated as a PDF, but to keep it backwards compatible we still show the old eReceipt view for image receipts
	const isImageReceiptSource = checkIsFileImage(source, file?.name);
	if (!hasReceiptSource(transaction) || isImageReceiptSource) {
	return <DistanceEReceipt transaction={transaction} />;
	}

Current code:

if (isDistanceRequest(transaction) && !isManualDistanceRequest(transaction) && !isOdometerDistanceRequest(transaction) && transaction) {
    // Distance eReceipts are now generated as a PDF, but to keep it backwards compatible we still show the old eReceipt view for image receipts
    const isImageReceiptSource = checkIsFileImage(source, file?.name);
    if (!hasReceiptSource(transaction) || isImageReceiptSource) {
        return <DistanceEReceipt transaction={transaction} />;
    }
}

Updated code:

if (isDistanceRequest(transaction) && !isManualDistanceRequest(transaction) && !isOdometerDistanceRequest(transaction) && transaction) {
    // Always render the distance eReceipt view for map-based distance requests so map preview does not disappear after receipt source reconciliation.
    return <DistanceEReceipt transaction={transaction} />;
}

What alternative solutions did you explore? (Optional)

I considered preserving the current image-only gate and adding special handling only for PDF sources in this flow, but that would encode transport format details into UI behavior and still be brittle across reconciliation states. Rendering DistanceEReceipt for eligible distance requests is the smallest and most stable fix.

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!