[BT-150] Migrate Settings - Profile (Part 1)

[mjasikowski]

Description

Current State:

• 4 routes in Settings Profile section use backTo parameter
• These routes handle profile and address settings

Implementation:

• Replace getRoute(..., backTo) with createDynamicRoute()
• Add source screens to entryScreens array for each route
• Remove backTo parameter from route definitions
• Test forward/back navigation

Scope

Routes (4):

Route Constant	Path
SETTINGS_PROFILE	settings/profile
SETTINGS_ADDRESS_COUNTRY	settings/profile/address/country
SETTINGS_ADDRESS_STATE	settings/profile/address/state
SETTINGS_CONTACT_METHODS	settings/profile/contact-methods

Usages

SETTINGS_PROFILE:

• src/pages/settings/InitialSettingsPage.tsx:225
• src/pages/ProfilePage.tsx:258

SETTINGS_ADDRESS_COUNTRY:

• src/components/CountrySelector.tsx:83

SETTINGS_ADDRESS_STATE:

• src/components/StateSelector.tsx (search for usage)

SETTINGS_CONTACT_METHODS:

• src/pages/domain/DomainResetPage.tsx:106
• src/libs/actions/User.ts:268,1277
• src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx:113
• src/pages/settings/Profile/Contacts/NewContactMethodConfirmMagicCodePage.tsx:45
• src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx:155,193,194,306,328
• src/pages/TeachersUnite/ImTeacherUpdateEmailPage.tsx:22,49
• src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx:116
• src/components/BookTravelButton.tsx:57

Files to modify:

• src/ROUTES.ts - Update route definitions
• src/libs/Navigation/types.ts - Remove backTo from params
• Components listed above

Migration Progress

• SETTINGS_PROFILE
• SETTINGS_ADDRESS_COUNTRY
• SETTINGS_ADDRESS_STATE
• SETTINGS_CONTACT_METHODS

Issue Owner

Current Issue Owner: @huult

Issue Owner

Current Issue Owner: @mananjadhav

[mananjadhav]

Taking this up as implementer.

[mananjadhav]

@mjasikowski I think it's best to tag @collectioneur as well. I am starting with this one.

Quick question for @collectioneur, we've got routes like settings/profile/address/country. I thought the nested routes are not support? Can you guide here?

[collectioneur]

@mananjadhav Feel free to start with the top layer that doesn’t require complex dynamic suffixes, for this batch, that’s just contact-methods.

In the meantime, I’ll work in parallel on the logic for the complex suffixes. I also noticed we need to support suffix layering (e.g., /profile + /address/country), so I’ll handle that as well. You're absolutely right though, that hasn't been implemented yet 😔

[mananjadhav]

Thanks for the information @collectioneur. I’ll get started with the base layer.

[mjasikowski]

@collectioneur I've created an issue for you: #83551