[BT-151] Migrate Settings - Profile (Part 2)

[mjasikowski]

Description

Current State:

• 4 routes handle contact methods and state selection
• These routes use backTo parameter for return navigation

Implementation:

• Replace getRoute(..., backTo) with createDynamicRoute()
• Add source screens to entryScreens array
• Remove backTo parameter from route definitions
• Test forward/back navigation

Scope

Routes (4):

Route Constant	Path
SETTINGS_CONTACT_METHOD_DETAILS	settings/profile/contact-methods/:contactMethod/details
SETTINGS_NEW_CONTACT_METHOD	settings/profile/contact-methods/new
SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE	settings/profile/contact-methods/new/confirm-magic-code
MONEY_REQUEST_STATE_SELECTOR	submit/state

Usages

SETTINGS_CONTACT_METHOD_DETAILS:

• src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx:120
• src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx:83

SETTINGS_NEW_CONTACT_METHOD:

• src/pages/settings/Profile/Contacts/NewContactMethodConfirmMagicCodePage.tsx:30

SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE:

• src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx:53,57

MONEY_REQUEST_STATE_SELECTOR:

• Search for usages in IOU/expense flows

Files to modify:

• src/ROUTES.ts - Update route definitions
• src/libs/Navigation/types.ts - Remove backTo from params
• Components listed above

Migration Progress

• SETTINGS_CONTACT_METHOD_DETAILS
• SETTINGS_NEW_CONTACT_METHOD
• SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE
• MONEY_REQUEST_STATE_SELECTOR

Issue Owner

Current Issue Owner: @mananjadhav

[mananjadhav]

Taking this up as implementer.

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!