Skip to content

[BT-129] Migrate Reports - Core (Part 1) #83365

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 5 core report routes use backTo parameter
  • These handle report viewing, details, and workspace changes

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
REPORT_WITH_ID r/:reportID
REPORT_WITH_ID_DETAILS r/:reportID/details
REPORT_WITH_ID_DETAILS_SHARE_CODE r/:reportID/details/shareCode
REPORT_WITH_ID_DETAILS_EXPORT r/:reportID/details/export/:connectionName
REPORT_WITH_ID_CHANGE_WORKSPACE r/:reportID/change-workspace

Usages

REPORT_WITH_ID:

  • src/pages/workspace/accounting/PolicyAccountingPage.tsx:636
  • src/pages/home/report/ReportActionsList.tsx:535,626
  • src/pages/home/report/PureReportActionItem.tsx:1135,1141
  • src/pages/home/report/ContextMenu/ContextMenuActions.tsx:477
  • src/pages/home/ReportScreen.tsx:637,762
  • src/pages/Share/ShareDetailsPage.tsx:129,153

REPORT_WITH_ID_DETAILS:

  • src/pages/home/report/ReportDetailsExportPage.tsx:108,133
  • src/pages/RoomMembersPage.tsx:248,414,429

REPORT_WITH_ID_DETAILS_SHARE_CODE:

  • Search for usages in report details flow

REPORT_WITH_ID_DETAILS_EXPORT:

  • Search for usages in report export flow

REPORT_WITH_ID_CHANGE_WORKSPACE:

  • Search for usages in workspace change flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • REPORT_WITH_ID
  • REPORT_WITH_ID_DETAILS
  • REPORT_WITH_ID_DETAILS_SHARE_CODE
  • REPORT_WITH_ID_DETAILS_EXPORT
  • REPORT_WITH_ID_CHANGE_WORKSPACE
Issue OwnerCurrent Issue Owner: @huult

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions