Skip to content

[BT-121] Migrate Money Request (Part 1) #83849

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 6 routes for new task completion and money request initiation
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (6):

Route Constant Path
NEW_TASK_DESCRIPTION new/task/description
NEW_TASK_SHARE_DESTINATION new/task/share-destination
MONEY_REQUEST_STEP_SEND_FROM create/:iouType/from/:transactionID/:reportID
MONEY_REQUEST_STEP_COMPANY_INFO create/:iouType/company-info/:transactionID/:reportID
MONEY_REQUEST_STEP_CONFIRMATION :action/:iouType/confirmation/:transactionID/:reportID
MONEY_REQUEST_STEP_AMOUNT :action/:iouType/amount/:transactionID/:reportID/:reportActionID?/:pageIndex?

Usages

NEW_TASK_DESCRIPTION:

  • src/pages/tasks/NewTaskDescriptionPage.tsx

NEW_TASK_SHARE_DESTINATION:

  • src/pages/tasks/TaskShareDestinationSelectorModal.tsx:37,117

MONEY_REQUEST_STEP_SEND_FROM:

  • Search for usages in money request flow

MONEY_REQUEST_STEP_COMPANY_INFO:

  • Search for usages in company info flow

MONEY_REQUEST_STEP_CONFIRMATION:

  • src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx:141
  • src/pages/iou/request/step/IOURequestStepScan/index.tsx:340,343,347,570,584
  • src/pages/iou/request/step/IOURequestStepScan/index.native.tsx:284,287,291,514,528
  • src/pages/iou/request/step/IOURequestStepReport.tsx:101
  • src/pages/iou/request/step/IOURequestStepParticipants.tsx:214,357,363
  • src/pages/iou/request/step/IOURequestStepHours.tsx:91
  • src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx:134,294,297,468
  • src/pages/iou/request/step/IOURequestStepDistanceMap.tsx:301,304,307,428

MONEY_REQUEST_STEP_AMOUNT:

  • Multiple usages in IOU request flow pages

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • NEW_TASK_DESCRIPTION
  • NEW_TASK_SHARE_DESTINATION
  • MONEY_REQUEST_STEP_SEND_FROM
  • MONEY_REQUEST_STEP_COMPANY_INFO
  • MONEY_REQUEST_STEP_CONFIRMATION
  • MONEY_REQUEST_STEP_AMOUNT
Issue OwnerCurrent Issue Owner: @huult

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions