Skip to content

[BT-126] Migrate Travel (Part 1) #83854

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 5 routes for travel terms and domain selection
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
TRAVEL_TCS travel/terms/:domain/accept
TRAVEL_UPGRADE travel/upgrade
TRAVEL_DOMAIN_SELECTOR travel/domain-selector
TRAVEL_DOMAIN_PERMISSION_INFO travel/domain-permission/:domain/info
TRAVEL_PUBLIC_DOMAIN_ERROR travel/public-domain-error

Usages

TRAVEL_TCS:

  • Search for usages in travel terms flow

TRAVEL_UPGRADE:

  • src/components/BookTravelButton.tsx:106
  • src/pages/Travel/TravelUpgrade.tsx

TRAVEL_DOMAIN_SELECTOR:

  • src/components/BookTravelButton.tsx:155
  • src/pages/Travel/DomainSelectorPage.tsx

TRAVEL_DOMAIN_PERMISSION_INFO:

  • Search for usages in domain permission flow

TRAVEL_PUBLIC_DOMAIN_ERROR:

  • Search for usages in public domain error flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • TRAVEL_TCS
  • TRAVEL_UPGRADE
  • TRAVEL_DOMAIN_SELECTOR
  • TRAVEL_DOMAIN_PERMISSION_INFO
  • TRAVEL_PUBLIC_DOMAIN_ERROR
Issue OwnerCurrent Issue Owner: @mananjadhav

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions