Skip to content

[BT-134] Migrate Room + Search #83856

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 6 routes for room management and search functionality
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (6):

Route Constant Path
SPLIT_BILL_DETAILS r/:reportID/split/:reportActionID
ROOM_MEMBERS r/:reportID/members
ROOM_MEMBER_DETAILS r/:reportID/members/:accountID
ROOM_INVITE r/:reportID/invite
SEARCH_REPORT search/view/:reportID/:reportActionID?
EXPENSE_REPORT_RHP e/:reportID

Usages

SPLIT_BILL_DETAILS:

  • src/pages/home/report/PureReportActionItem.tsx:1127
  • src/components/ReportActionItem/MoneyRequestAction.tsx:119

ROOM_MEMBERS:

  • src/pages/RoomInvitePage.tsx:201
  • src/pages/ReportDetailsPage.tsx:398
  • src/pages/RoomMemberDetailsPage.tsx:47

ROOM_MEMBER_DETAILS:

  • src/pages/RoomMembersPage.tsx:367

ROOM_INVITE:

  • src/pages/RoomMembersPage.tsx:132
  • src/pages/ReportDetailsPage.tsx:412

SEARCH_REPORT:

  • src/pages/TransactionDuplicate/Review.tsx:74
  • src/pages/Search/SearchReportVerifyAccountPage.tsx:14
  • src/pages/Search/SearchPage.tsx:493,505,519
  • src/libs/SettlementButtonUtils.ts:43,62
  • src/libs/SearchUIUtils.ts:1635
  • src/libs/ReportUtils.ts:10134
  • src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx:116
  • src/components/Search/index.tsx:835,845
  • src/components/ParentNavigationSubtitle.tsx:161
  • src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx:397
  • src/libs/PaymentUtils.ts:152
  • src/components/ReportActionItem/MoneyRequestAction.tsx:130,138
  • src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx:47

EXPENSE_REPORT_RHP:

  • src/pages/home/report/ExpenseReportVerifyAccountPage.tsx:16,17
  • src/libs/SettlementButtonUtils.ts:47,70
  • src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx:119
  • src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx:526

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SPLIT_BILL_DETAILS
  • ROOM_MEMBERS
  • ROOM_MEMBER_DETAILS
  • ROOM_INVITE
  • SEARCH_REPORT
  • EXPENSE_REPORT_RHP
Issue OwnerCurrent Issue Owner: @mananjadhav

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions