Skip to content

[BT-135] Migrate Search + Bank + New Task #83857

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 8 routes for search, bank accounts, and new task creation
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (8):

Route Constant Path
SEARCH_MONEY_REQUEST_REPORT search/r/:reportID
SEARCH_MONEY_REQUEST_REPORT_HOLD_TRANSACTIONS search/r/:reportID/hold
BANK_ACCOUNT_VERIFY_ACCOUNT bank-account/verify-account
BANK_ACCOUNT_WITH_STEP_TO_OPEN bank-account/:stepToOpen
NEW_TASK new/task
NEW_TASK_ASSIGNEE new/task/assignee
NEW_TASK_DETAILS new/task/details
NEW_TASK_TITLE new/task/title

Usages

SEARCH_REPORT:

  • src/pages/TransactionDuplicate/Review.tsx:74
  • src/pages/Search/SearchReportVerifyAccountPage.tsx:14
  • src/pages/Search/SearchPage.tsx:493,505,519
  • src/libs/SettlementButtonUtils.ts:43,62
  • src/libs/SearchUIUtils.ts:1635
  • src/libs/ReportUtils.ts:10134
  • src/components/SelectionListWithSections/Search/TransactionGroupListExpanded.tsx:116
  • src/components/Search/index.tsx:835,845
  • src/components/ParentNavigationSubtitle.tsx:161
  • src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx:397
  • src/libs/PaymentUtils.ts:152
  • src/components/ReportActionItem/MoneyRequestAction.tsx:130,138
  • src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx:47

BANK_ACCOUNT_WITH_STEP_TO_OPEN:

  • src/libs/ReportUtils.ts:1785
  • src/components/SettlementButton/index.tsx:606
  • src/components/Search/SearchPageHeader/SearchFiltersBar.tsx:844
  • src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPageEmptyState.tsx:57
  • src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx:73
  • src/pages/ReimbursementAccount/USD/ConnectBankAccount/components/Enable2FACard.tsx:35
  • src/pages/ReimbursementAccount/ReimbursementAccountVerifyAccountPage.tsx:16,18
  • src/pages/ReimbursementAccount/NonUSD/Finish/index.tsx:70
  • src/components/Navigation/DebugTabView.tsx:83
  • src/components/KYCWall/BaseKYCWall.tsx:145,157,175
  • src/libs/actions/ReimbursementAccount/navigation.ts:22

SEARCH_MONEY_REQUEST_REPORT:

  • src/pages/TransactionMerge/ConfirmationPage.tsx:104
  • src/pages/Search/SearchMoneyRequestReportVerifyAccountPage.tsx:16,17
  • src/pages/NewReportWorkspaceSelectionPage.tsx:110
  • src/libs/actions/IOU/index.ts:996
  • src/libs/SettlementButtonUtils.ts:58
  • src/components/Search/index.tsx:829
  • src/components/ParentNavigationSubtitle.tsx:140
  • src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx:248
  • src/pages/Search/SearchSelectedNarrow.tsx:65
  • src/pages/Search/EmptySearchView.tsx:229
  • src/libs/PaymentUtils.ts:150
  • src/libs/Navigation/helpers/getReportURLForCurrentContext.ts:58

BANK_ACCOUNT_VERIFY_ACCOUNT:

  • src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx:159,179

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SEARCH_MONEY_REQUEST_REPORT
  • SEARCH_MONEY_REQUEST_REPORT_HOLD_TRANSACTIONS
  • BANK_ACCOUNT_VERIFY_ACCOUNT
  • BANK_ACCOUNT_WITH_STEP_TO_OPEN
  • NEW_TASK
  • NEW_TASK_ASSIGNEE
  • NEW_TASK_DETAILS
  • NEW_TASK_TITLE
Issue OwnerCurrent Issue Owner: @huult

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions