Skip to content

[BT-136] Migrate Money Request (Part 2) #83858

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 6 routes for money request tax and category steps
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (6):

Route Constant Path
MONEY_REQUEST_STEP_TAX_RATE :action/:iouType/taxRate/:transactionID/:reportID
MONEY_REQUEST_STEP_TAX_AMOUNT :action/:iouType/taxAmount/:transactionID/:reportID
MONEY_REQUEST_STEP_CATEGORY :action/:iouType/category/:transactionID/:reportID/:reportActionID?
MONEY_REQUEST_ATTENDEE :action/:iouType/attendees/:transactionID/:reportID
MONEY_REQUEST_ACCOUNTANT :action/:iouType/accountant/:transactionID/:reportID
MONEY_REQUEST_UPGRADE :action/:iouType/upgrade/:transactionID/:reportID

Usages

MONEY_REQUEST_STEP_TAX_RATE:

  • Search for usages in tax rate selection flow

MONEY_REQUEST_STEP_TAX_AMOUNT:

  • src/components/ReportActionItem/MoneyRequestView.tsx:1044

MONEY_REQUEST_STEP_CATEGORY:

  • src/pages/iou/request/step/IOURequestStepUpgrade.tsx:117
  • src/pages/iou/request/step/IOURequestStepParticipants.tsx:355,374
  • src/pages/iou/request/step/IOURequestStepCategory.tsx:214
  • src/pages/iou/SplitExpensePage.tsx:169
  • src/libs/ReportUtils.ts:11193,11273,11307
  • src/components/ReportActionItem/MoneyRequestView.tsx:967,978
  • src/components/MoneyRequestConfirmationListFooter.tsx:610

MONEY_REQUEST_ATTENDEE:

  • Search for usages in attendee selection flow

MONEY_REQUEST_ACCOUNTANT:

  • src/pages/iou/request/step/IOURequestStepAccountant.tsx

MONEY_REQUEST_UPGRADE:

  • Search for usages in upgrade flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • MONEY_REQUEST_STEP_TAX_RATE
  • MONEY_REQUEST_STEP_TAX_AMOUNT
  • MONEY_REQUEST_STEP_CATEGORY
  • MONEY_REQUEST_ATTENDEE
  • MONEY_REQUEST_ACCOUNTANT
  • MONEY_REQUEST_UPGRADE
Issue OwnerCurrent Issue Owner: @mananjadhav

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions