Skip to content

[BT-138] Migrate Workspace - Categories Settings + Tags #83860

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 5 routes for category settings and workspace tags
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
SETTINGS_CATEGORY_EDIT settings/:policyID/category/:categoryName/edit
SETTINGS_CATEGORY_SETTINGS settings/:policyID/category/:categoryName
WORKSPACE_TAGS workspaces/:policyID/tags
WORKSPACE_TAGS_SETTINGS workspaces/:policyID/tags/settings
WORKSPACE_TAG_CREATE workspaces/:policyID/tags/new

Usages

SETTINGS_CATEGORY_EDIT:

  • Search for usages in settings category edit flow

SETTINGS_CATEGORY_SETTINGS:

  • Search for usages in settings category settings flow

WORKSPACE_TAGS:

  • src/pages/workspace/tags/ImportMultiLevelTagsSettingsPage.tsx:71
  • src/pages/workspace/rules/IndividualExpenseRulesSection.tsx:59
  • src/libs/ReportUtils.ts:11549
  • src/pages/workspace/tags/ImportedTagsPage.tsx:132
  • src/pages/workspace/tags/ImportedMultiLevelTagsPage.tsx:48
  • src/pages/workspace/rules/RulesBillableDefaultPage.tsx:55

WORKSPACE_TAGS_SETTINGS:

  • Search for usages in tags settings flow

WORKSPACE_TAG_CREATE:

  • Search for usages in tag creation flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SETTINGS_CATEGORY_EDIT
  • SETTINGS_CATEGORY_SETTINGS
  • WORKSPACE_TAGS
  • WORKSPACE_TAGS_SETTINGS
  • WORKSPACE_TAG_CREATE
Issue OwnerCurrent Issue Owner: @mananjadhav

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions