-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[BT-138] Migrate Workspace - Categories Settings + Tags #83860
Copy link
Copy link
Open
Labels
InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
Description
Current State:
- 5 routes for category settings and workspace tags
- These routes use
backToparameter for return navigation
Implementation:
- Replace
getRoute(..., backTo)withcreateDynamicRoute() - Add source screens to
entryScreensarray - Remove
backToparameter from route definitions - Test forward/back navigation
Scope
Routes (5):
| Route Constant | Path |
|---|---|
SETTINGS_CATEGORY_EDIT |
settings/:policyID/category/:categoryName/edit |
SETTINGS_CATEGORY_SETTINGS |
settings/:policyID/category/:categoryName |
WORKSPACE_TAGS |
workspaces/:policyID/tags |
WORKSPACE_TAGS_SETTINGS |
workspaces/:policyID/tags/settings |
WORKSPACE_TAG_CREATE |
workspaces/:policyID/tags/new |
Usages
SETTINGS_CATEGORY_EDIT:
- Search for usages in settings category edit flow
SETTINGS_CATEGORY_SETTINGS:
- Search for usages in settings category settings flow
WORKSPACE_TAGS:
src/pages/workspace/tags/ImportMultiLevelTagsSettingsPage.tsx:71src/pages/workspace/rules/IndividualExpenseRulesSection.tsx:59src/libs/ReportUtils.ts:11549src/pages/workspace/tags/ImportedTagsPage.tsx:132src/pages/workspace/tags/ImportedMultiLevelTagsPage.tsx:48src/pages/workspace/rules/RulesBillableDefaultPage.tsx:55
WORKSPACE_TAGS_SETTINGS:
- Search for usages in tags settings flow
WORKSPACE_TAG_CREATE:
- Search for usages in tag creation flow
Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom params- Components listed above
Migration Progress
-
SETTINGS_CATEGORY_EDIT -
SETTINGS_CATEGORY_SETTINGS -
WORKSPACE_TAGS -
WORKSPACE_TAGS_SETTINGS -
WORKSPACE_TAG_CREATE
Issue Owner
Current Issue Owner: @mananjadhavReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2