Expense - Remove from report option is shown when the expense is unreported

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.36-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84512
Email or phone of affected tester (no customers): soindjosdjosddjsiodn@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Preconditon:

• Have at least one workspace.
• Workspace chat has at least one open report.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Create an expense.
4. Open the expense.
5. Click More > Move to report.

Expected Result:

Remove from report option will not be shown because the expense is unreported.

Actual Result:

Remove from report option is shown when the expense is unreported.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7100406_1773262975084.13.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84512

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #84512 - "Feat: Add 'Move to report' in the 'More' menu of a one-expense report" by @nyomanjyotisa (High confidence)
Related Issues: #83884

Recommendation: REVERT

PR #84512 introduced a logic error when navigating to the "Move to report" screen for unreported expenses. The PR passes the parent chat report ID (self DM) to the edit report screen, which incorrectly triggers the "Remove from report" option to display for unreported expenses.

Labels: Keeping DeployBlockerCash (Frontend bug in App repo)

📋 Detailed Analysis

Evidence

PR #84512 added the "Move to report" functionality to the More menu for single-expense reports. When an unreported expense (created in a self DM) is moved, the code navigates using the parent report ID:

In MoneyRequestHeader.tsx (from PR #84512):

const iouType = isExpenseReportUtils(parentReport) ? CONST.IOU.TYPE.SUBMIT : CONST.IOU.TYPE.TRACK;
setSelectedTransactions([transaction.transactionID]);
Navigation.navigate(ROUTES.MONEY_REQUEST_EDIT_REPORT.getRoute(CONST.IOU.ACTION.EDIT, iouType, parentReport.reportID, true, Navigation.getActiveRoute()));

For an unreported expense:

• parentReport is the self DM chat (not an expense report)
• The navigation passes parentReport.reportID (the self DM chat ID)

Verification

The bug appears in IOURequestEditReportCommon.tsx at lines 115-116:

const shouldShowRemoveFromReport =
    !!(selectedReportID && selectedReportID !== CONST.REPORT.UNREPORTED_REPORT_ID && selectedReport) && isEditing && isOwner && !isReportIOU && !isCardTransaction;

This logic assumes that any report ID that is not '0' (UNREPORTED_REPORT_ID) means the expense is in a report. However, PR #84512 now passes the self DM chat report ID for unreported expenses, which satisfies the condition selectedReportID !== CONST.REPORT.UNREPORTED_REPORT_ID, incorrectly showing "Remove from report".

The affected files from PR #84512:

• src/components/MoneyRequestHeader.tsx - Added MOVE_EXPENSE action with navigation
• src/components/MoneyReportHeader.tsx - Added MOVE_EXPENSE action with navigation
• src/libs/ReportSecondaryActionUtils.ts - Added logic to show Move Expense option

Root Cause

PR #84512 broke an existing assumption in the "Move to report" flow. The code in IOURequestEditReportCommon.tsx assumes that passing a real report ID (not '0') means the expense is already in a report. The new "Move to report" functionality passes the parent chat report ID even for unreported expenses, causing the "Remove from report" option to display incorrectly.

The logic needs to distinguish between:

1. An expense in an actual expense report (should show "Remove from report")
2. An unreported expense being moved from a chat (should NOT show "Remove from report")