Secondary email appears instead of primary when searching user via secondary email again

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.39-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/Expensify/issues/579751
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: macOS Sequoia 15.4.1 - Safari
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com
2. Create a Workspace
3. Invite a user to a workspace using their secondary login.
4. Verify the user has been added to the workspace and the primary email appears as a contact method
5. Try inviting the user again using the same login used in step 3

Expected Result:

The primary email is dispalyed as a contact method after trying to inviting the user again using their secondary email

Actual Result:

Secondary email appears instead of primary email when searching user via secondary email again

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7086743_1771917916444.33.mp4

View all open jobs on GitHub

[MelvinBot]

I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here).

Failure details: https://github.com/Expensify/Expensify/actions/runs/23245286552

[harryautomazione]

Hi everyone, here is my proposal for this issue.

Root Cause

The root cause is in the offline filtering logic used during member searches.

When searching a user by their secondary email, getValidOptions (in src/libs/OptionsListUtils/index.ts) filters personalDetails by matching the search string against personalDetail.login (which stores the primary email).

If the user is already in PersonalDetails, the offline match fails. This triggers getUserToInviteOption to create an optimistic invitation option using the searched secondary email, creating a duplicate or invitation action.

---

Proposed Solution

Update getValidOptions to support resolving candidate options when searched by an existing secondary email lookup.

We can pass invitedEmailsToAccountIDsDraft (the invite mapping) into getValidOptions config parameters.

File: src/libs/OptionsListUtils/index.ts
Inside the filtering callback (filteringFunction), add a quick draft-based lookup:

const accountIDFromDraft = config.invitedEmailsToAccountIDsDraft?.[term];
const isMatchedByDraft = accountIDFromDraft && personalDetail.accountID === accountIDFromDraft;

if (isMatchedByDraft) { return true; }

Also, update useSearchSelector.base.ts to forward this mapping under SEARCH_CONTEXT_MEMBER_INVITE.

---

Test Plan

Verify behaviour by creating/modifying unit test scenarios targeting getValidOptions lookup verification on valid mapping parameters.

---

Let me know if this approach looks good to you! Happy to hear your feedback :)

[melvin-bot]

📣 @harryautomazione! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[harryautomazione]

@MelvinBot
I already provided my details on another issue, but posting them here again for reference:

Contributor details
Your Expensify account email: harry.automazione@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016e9717b1fd91ab12

Please let me know if any further action is required from my side.

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!