Track distance - Two No route found errors appears on distance track map

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.41-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-10911/folder/13176744/41237148/1264591117?sort=%2Bstatus_id
Email or phone of affected tester (no customers): gocemate+b21549066112@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Other

Action Performed:

1. Go offline
2. Create track distance map
3. Go online
4. Open the expense
5. Click on distance field

Expected Result:

There should be only one error message: "No route found through the waypoints. Please edit the waypoints and try again."

Actual Result:

There is a two error messages: "No route found through the waypoints. Please edit the waypoints and try again." appears on both RHP modals

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a distance expense has a route error (e.g., "No route found through the waypoints"), the error message appears twice — once in the expense receipt area and again on the distance editing page. Clicking the distance field from the expense details opens both RHP modals with the same error visible.

What is the root cause of that problem?

The errorsWithoutReportCreation memo in MoneyRequestReceiptView unconditionally includes transaction.errorFields.route for all expense types:

App/src/components/ReportActionItem/MoneyRequestReceiptView.tsx

Lines 279 to 285 in b89df6b

	const errorsWithoutReportCreation = useMemo(
	() => ({
	...(transaction?.errorFields?.route ?? transaction?.errorFields?.waypoints ?? transaction?.errors),
	...parentReportAction?.errors,
	}),
	[transaction?.errorFields?.route, transaction?.errorFields?.waypoints, transaction?.errors, parentReportAction?.errors],
	);

This causes the route error to render in the receipt area via OfflineWithFeedback. However, for distance requests, the same error is already shown in IOURequestStepDistance via hasRouteError and DotIndicatorMessage:

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 152 in b89df6b

const hasRouteError = !!currentTransaction?.errorFields?.route;

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Lines 571 to 576 in b89df6b

	{((shouldShowAtLeastTwoDifferentWaypointsError && atLeastTwoDifferentWaypointsError) || duplicateWaypointsError || hasRouteError) && (
	<DotIndicatorMessage
	style={[styles.mh4, styles.mv3]}
	messages={getError()}
	type="error"
	/>

When the user clicks the distance field, the distance editing page opens in the RHP. At that point, both the receipt area (behind) and the editing page (in front) show the route error — resulting in two visible error messages.

What changes do you think we should make in order to solve the problem?

In MoneyRequestReceiptView, skip errorFields.route from the errorsWithoutReportCreation memo when the transaction is a distance request. The isDistanceRequest variable already exists at line 154, so the fix is a small conditional in the memo:

• When isDistanceRequest is true: use errorFields.waypoints ?? errors (skip route errors)
• When isDistanceRequest is false: use the existing chain errorFields.route ?? errorFields.waypoints ?? errors

This ensures the route error only appears in the distance editing page where the user can actually act on it (edit waypoints), while non-distance errors and waypoint errors continue to display correctly in the receipt area.

Compare: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/85901-fix-duplicate-route-error?expand=1