LHN - Chat with only a task doesn't appear in the LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.44-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85831
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook Air 15.4.1
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to https://staging.new.expensify.com
2. As user A, create a group chat with user B and user C
3. As user A, create a task in the group chat without selecting an assignee
4. Sign in as user B

Expected Result:

Group chat with a task should appear in the LHN

Actual Result:

Chat with only a task doesn't appear in the LHN

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7113163_1774462422426.Recording__1890.mp4

View all open jobs on GitHub

[MelvinBot]

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23562356813

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user A creates a group chat with user B and user C, then creates a task in that group chat without selecting an assignee, user B does not see that group chat in the LHN after signing in.

Expected: The group chat that contains the task appears in the LHN.
Actual: A chat that only contains a task is hidden from the LHN.

What is the root cause of that problem?

The LHN filter hides empty chats when excludeEmptyChats is enabled, and it depends on isEmptyReport() for that decision.

App/src/libs/ReportUtils.ts

Lines 9605 to 9671 in a8d4105

	const canHideReport = shouldHideReport(report, currentReportId, isReportArchived);
	// Drafts already return early above, so no draft check needed here
	if (isChatThreadReport && isEmptyChat) {
	const isParentDeleted = !isEmptyObject(parentReportAction) && isDeletedAction(parentReportAction);
	const isParentPendingDelete = !isEmptyObject(parentReportAction) && parentReportAction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
	const hasReplies = (parentReportAction?.childVisibleActionCount ?? 0) > 0;
	if ((isParentDeleted || isParentPendingDelete) && !hasReplies) {
	return null;
	}
	}
	// Include reports if they are pinned
	if (report.isPinned) {
	return CONST.REPORT_IN_LHN_REASONS.PINNED_BY_USER;
	}
	const reportIsSettled = report.statusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;
	// Always show IOU reports with violations unless they are reimbursed
	if (isExpenseRequest(report) && doesReportHaveViolations && !reportIsSettled) {
	return CONST.REPORT_IN_LHN_REASONS.HAS_IOU_VIOLATIONS;
	}
	// Hide only chat threads that haven't been commented on (other threads are actionable)
	if (isChatThreadReport && canHideReport && isEmptyChat) {
	return null;
	}
	// Include reports that have errors from trying to add a workspace
	// If we excluded it, then the red-brock-road pattern wouldn't work for the user to resolve the error
	if (report.errorFields?.addWorkspaceRoom) {
	return CONST.REPORT_IN_LHN_REASONS.HAS_ADD_WORKSPACE_ROOM_ERRORS;
	}
	// All unread chats (even archived ones) in GSD mode will be shown. This is because GSD mode is specifically for focusing the user on the most relevant chats, primarily, the unread ones
	if (isInFocusMode) {
	const oneTransactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, currentReportActions);
	const oneTransactionThreadReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${oneTransactionThreadReportID}`];
	return isUnread(report, oneTransactionThreadReport, isReportArchived) && getReportNotificationPreference(report) !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE
	? CONST.REPORT_IN_LHN_REASONS.IS_UNREAD
	: null;
	}
	// Archived reports should always be shown when in default (most recent) mode. This is because you should still be able to access and search for the chats to find them.
	if (isInDefaultMode && isArchivedNonExpenseReport(report, isReportArchived)) {
	return CONST.REPORT_IN_LHN_REASONS.IS_ARCHIVED;
	}
	// Hide chats between two users that haven't been commented on from the LNH
	const isSelfDMWithVisiblePreference = isSelfDM(report) && !isHiddenForCurrentUser(report);
	if (
	excludeEmptyChats &&
	isEmptyChat &&
	isChatReport(report) &&
	!isPolicyExpenseChat(report) &&
	!isTripRoom(report) &&
	!isConciergeChatReport(report) &&
	!isSystemChatReport &&
	!isSelfDMWithVisiblePreference &&
	canHideReport
	) {
	return null;
	}

isEmptyReport() currently relies on report.lastMessageText and generic last-visible-message text. For task creation actions (ADD_COMMENT with originalMessage.taskReportID), this path can still evaluate as empty.

App/src/libs/ReportUtils.ts

Lines 9026 to 9037 in a8d4105

	if (!report) {
	return true;
	}
	if (report.lastMessageText) {
	return false;
	}
	const lastVisibleMessage = getLastVisibleMessage(report.reportID, isReportArchived);
	return !lastVisibleMessage.lastMessageText;
	}

In contrast, LHN message rendering already has explicit handling for created-task actions via getTaskCreatedMessage(), which means task-only chats are intended to be represented as meaningful chat activity.

App/src/libs/OptionsListUtils/index.ts

Lines 754 to 758 in a8d4105

	} else if (isTaskAction(lastReportAction)) {
	lastMessageTextFromReport = formatReportLastMessageText(getTaskReportActionMessage(translate, lastReportAction).text);
	} else if (isCreatedTaskReportAction(lastReportAction)) {
	lastMessageTextFromReport = getTaskCreatedMessage(translate, lastReportAction, getReportOrDraftReport(lastReportAction?.childReportID));
	} else if (

What changes do you think we should make in order to solve the problem?

1. Treat created-task actions as non-empty activity when computing isEmptyReport().

App/src/libs/ReportUtils.ts

Lines 9026 to 9037 in a8d4105

	if (!report) {
	return true;
	}
	if (report.lastMessageText) {
	return false;
	}
	const lastVisibleMessage = getLastVisibleMessage(report.reportID, isReportArchived);
	return !lastVisibleMessage.lastMessageText;
	}

function generateIsEmptyReport(report: OnyxEntry<Report>, isReportArchived: boolean | undefined): boolean {
    if (!report) {
        return true;
    }

    if (report.lastMessageText) {
        return false;
    }

    const canWrite = canUserPerformWriteAction(report, isReportArchived);
    const lastVisibleAction = getLastVisibleActionReportActionsUtils(report.reportID, canWrite);

    // A parent chat with only a created-task action must still be treated as non-empty
    // so it remains visible in the LHN.
    if (isCreatedTaskReportAction(lastVisibleAction)) {
        return false;
    }

    const lastVisibleMessage = getLastVisibleMessage(report.reportID, isReportArchived);
    return !lastVisibleMessage.lastMessageText;
}

2. Add a regression test for shouldReportBeInOptionList() with excludeEmptyChats: true to ensure a report containing only a created-task parent action is still included.

App/tests/unit/ReportUtilsTest.ts

Lines 5653 to 5699 in a8d4105

	isInFocusMode,
	betas,
	doesReportHaveViolations: false,
	excludeEmptyChats: false,
	draftComment: '',
	isReportArchived: undefined,
	}),
	).toBeFalsy();
	});
	it('should return false when the report is the single transaction thread', async () => {
	const expenseReport = buildOptimisticExpenseReport({chatReportID: '212', policyID: '123', payeeAccountID: 100, total: 122, currency: 'USD', betas: [CONST.BETAS.ALL]});
	const expenseTransaction = buildOptimisticTransaction({
	transactionParams: {
	amount: 100,
	currency: 'USD',
	reportID: expenseReport.reportID,
	},
	});
	const expenseCreatedAction = buildOptimisticIOUReportAction({
	type: 'create',
	amount: 100,
	currency: 'USD',
	comment: '',
	participants: [],
	transactionID: expenseTransaction.transactionID,
	iouReportID: expenseReport.reportID,
	});
	const transactionThreadReport = buildTransactionThread(expenseCreatedAction, expenseReport);
	expenseCreatedAction.childReportID = transactionThreadReport.reportID;
	const currentReportId = '1';
	const isInFocusMode = false;
	const betas = [CONST.BETAS.DEFAULT_ROOMS];
	await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`, expenseReport);
	await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`, {
	[expenseCreatedAction.reportActionID]: expenseCreatedAction,
	});
	expect(
	shouldReportBeInOptionList({
	report: transactionThreadReport,
	chatReport: mockedChatReport,
	currentReportId,
	isInFocusMode,
	betas,
	doesReportHaveViolations: false,
	excludeEmptyChats: false,

it('should return true for chat with only created-task action when excludeEmptyChats is true', async () => {
    const report = LHNTestUtils.getFakeReport();
    const createdTaskAction = ReportTestUtils.buildOptimisticTaskCommentReportAction(
        'taskReportID',
        'Test task',
        0,
        'task for Test task',
        report.reportID,
    ).reportAction;

    await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`, {
        [createdTaskAction.reportActionID]: createdTaskAction,
    });

    expect(
        shouldReportBeInOptionList({
            report,
            chatReport: mockedChatReport,
            currentReportId: '',
            isInFocusMode: false,
            betas: [CONST.BETAS.DEFAULT_ROOMS],
            doesReportHaveViolations: false,
            excludeEmptyChats: true,
            draftComment: '',
            isReportArchived: undefined,
        }),
    ).toBe(true);
});

[dmkt9]

It seems Melvin failed to add the External label. I can help review proposals on this issue if needed.

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...