Skip to content

Dismiss 3DS review RHP on second device after review completes on first device #86772

@MelvinBot

Description

@MelvinBot

Improvement: Dismiss 3DS review RHP on second device after review is completed on first device

Slack thread: https://expensify.slack.com/archives/C09AP9F437A/p1774980516031039

Current Behavior

When a user is reviewing a 3DS transaction on multiple devices simultaneously, completing the review on one device leaves the other device showing a broken/"humpty dumpty" state for the transaction that no longer needs review.

This also occurs when an Optimistic MERGE null update is issued for a specific transactionID on the second device.

Expected Behavior

After a 3DS transaction review is completed on one device, the review RHP (Right Hand Panel) on any other device should gracefully dismiss/disappear rather than showing a broken state.

Analysis

The two cases where a full SET of transactions pending review occurs are:

  • OpenApp / reconnect — wouldn't happen if actively using the app, unless force-quitting mid-review
  • GetTransactionsPending3DSReview — happens at the beginning of a review; for this to cause an issue, a new transaction would need to be issued mid-review AND expire sooner than the current one (unlikely)

The team concluded there are no normal use cases where dismissing the RHP on the second device would make the app appear broken to the user.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions