Bank account - Signer info tab not allows user to proceed

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84904
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

Precondition: open Wallet page

1. Begin adding a non-USD business bank account on Wallet (e.g. AUD)
2. Get to the Signer info step - "Are you a director at [company name]?"
3. Choose No
4. Click Confirm
5. Change the selection to Yes
6. Click Confirm
7. Go back to "Are you a director at [company name]?"
8. Select No once again
9. Click Confirm
10. Click workspace link in error message

Expected Result:

Step 4: User see an error message above the button: "Please connect this bank account to a workspace to invite a director to sign."
Step 6: User redirected to "What's your legal name" step
Step 10: "workspace" link navigates to the Workspace page

Actual Result:

Step 4 and 6: User see an error message above the button: "Please connect this bank account to a workspace to invite a director to sign."
Step 10; new browser tab opens with URL https://staging.new.expensify.com/bank-account/new/global/signer-info/is-director/workspaces

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dominictb

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84904

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Problem: Two bugs introduced by #84904 in the signer info step of the non-USD bank account flow.

Bug 1 — "Yes" blocked for AUD when no policyID (Steps 4–6)

In src/pages/ReimbursementAccount/NonUSD/SignerInfo/index.tsx:131, the guard added by PR #84904 is:

if (!policyID && (!value || currency === CONST.CURRENCY.AUD)) {

For AUD + "Yes" (value=true): !policyID && (false || true) = !policyID — so selecting "Yes, I am a director" is incorrectly blocked for AUD when no workspace is connected. The user should be allowed to proceed through the signer details form when they confirm they are a director.

Bug 2 — Workspace link navigates to wrong URL (Step 10)

In src/pages/ReimbursementAccount/NonUSD/SignerInfo/index.tsx:198, the error message passes ROUTES.WORKSPACES_LIST.getRoute() which returns the string 'workspaces' (no leading /). This is embedded in an HTML anchor: <a href="workspaces">. Since it's a relative URL, the browser resolves it against the current path, producing …/signer-info/is-director/workspaces instead of /workspaces.

Recommended Fix:

1. Change the guard condition at line 131 to only block when the user selects "No" (not a director), since that's the only path that immediately requires a policyID to invite an external signer:

   if (!policyID && !value) {

2. Prepend / to the route in the error message at line 198 to make it an absolute path:

   message={translate('signerInfoStep.error.connectToWorkspace', `/${ROUTES.WORKSPACES_LIST.getRoute()}`)}

Investigation details

• PR Fix non-usd flow api error #84904 added the handleIsDirectorSelected policyID guard and the connectToWorkspace error message. Before this PR, there was no such check — selecting Yes/No always navigated forward.
• For AUD directors, the flow eventually needs a policyID at the ENTER_EMAIL step (line 84–87). However, blocking at the director question prevents the user from even entering their signer details. The policyID requirement could be enforced later in the flow instead of prematurely blocking at this step.
• The ROUTES.WORKSPACES_LIST route is defined as {route: 'workspaces', getRoute: ...} in src/ROUTES.ts:179 — all route strings in this codebase omit the leading /, which is fine for React Navigation but not for raw HTML <a href> tags.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.