Android - QBD - "QuickBooks Desktop setup" page is not scrollable

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.54-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85229
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

1. Launch Expensify app in landscape mode.
2. Go to workspace settings > Accounting (enable in More features).
3. Tap Connect QuickBooks Desktop.
4. Upgrade workspace if needed.
5. Scroll "QuickBooks Desktop setup" page.

Expected Result:

"QuickBooks Desktop setup" page should be scrollable.

Actual Result:

"QuickBooks Desktop setup" page is not scrollable.
Part of the content is blocked by Got it button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7125040_1775667447381.Screen_Recording_20260409_005524_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @GCyganek

[melvin-bot]

@mjasikowski recently merged #85229, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
Related Issues: None

Recommendation: ROLL FORWARD

PR #85229 unlocked landscape mode for all screens but fixed scrollability only for some pages (e.g., SageIntacctPrerequisitesPage) while missing QuickBooksDesktopSetupPage. The fix is straightforward - add a ScrollView wrapper to the QBD setup page - and reverting would re-lock landscape mode for all users, which is a bigger regression.

Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers)
Labels: No label changes - DeployBlockerCash is correct (App PR caused the issue, staging-only)

Detailed Analysis

Evidence

• The issue body itself references PR Unlock landscape mode #85229 as the linked PR ("@mjasikowski recently merged Unlock landscape mode #85229")
• PR Unlock landscape mode #85229 merged on 2026-04-07 and is in the current StagingDeployCash checklist
• The bug is staging-only ("Reproducible in production? N/A - new feature, doesn't exist in prod"), which confirms it was introduced by a staging PR
• The bug only manifests in landscape mode on Android, which is exactly what PR Unlock landscape mode #85229 enabled

Verification

• Affected file: src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx
• PR Unlock landscape mode #85229 does NOT directly modify QuickBooksDesktopSetupPage.tsx - confirmed via gh pr diff 85229
• However, PR Unlock landscape mode #85229 did fix the similar SageIntacctPrerequisitesPage.tsx by replacing a plain View wrapper with a ScrollView (visible in the diff), while leaving the QBD page untreated
• QuickBooksDesktopSetupPage.tsx uses a View with flex1 around its content with a FixedFooter inside - no ScrollView is present, so content is unscrollable in landscape when vertical space is reduced

Root Cause

Before PR #85229, landscape mode was locked on phones (Android orientation XML files enforced portrait-only). PR #85229 removed those locks and added landscape support, but the QuickBooks Desktop setup page was never updated to support landscape layout. The page renders its content in a non-scrollable View with a FixedFooter containing the "Done" button. In landscape mode on a phone, the reduced vertical height means the footer overlaps the content with no way to scroll past it. The fix is to wrap the page content in a ScrollView, the same pattern applied to SageIntacctPrerequisitesPage in that same PR.