[$250] Wallet-Share bank account shows error

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73427
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: User Settings

Action Performed:

Pre-condition:

1. Add a VBA ( region Bank ending 1111)
2. Add few members as admin

Steps:

1. Launch app
2. Go to wallet
3. Tap 3 dots - share
4. Select all members
5. Tap share

Expected Result:

Trying to share account with members must not show error.

Actual Result:

Trying to share account with members shows error.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7124980_1775669868337.Screenrecorder-2026-04-08-23-06-59-591.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mountiny

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022043744564338133076
• Upwork Job ID: 2043744564338133076
• Last Price Increase: 2026-04-13

[MelvinBot]

Proposal

Root Cause: The backend rejects the ShareBankAccount API call when the sharee(s) have unvalidated Expensify accounts, but the App only surfaces a generic error message ("An unexpected error occurred while trying to share bank account. Please try again.") from its hardcoded failureData (BankAccounts.ts:1466). The backend's specific error reason is never displayed to the user.

This is the same underlying issue as #87502 (sharing to unvalidated accounts). The user in this issue likely has workspace members with unvalidated accounts.

Solution: Update the shareBankAccount function to use the server's error response instead of the hardcoded translation key. This is the standard Onyx pattern — use failureData only as a network-down fallback, and let onyx updates from the server response provide the real error.

Specifically:

1. In BankAccounts.ts:1460-1468, change failureData to clear loading state but not set a hardcoded error — let the server response populate errors via its own Onyx update.
2. If the server doesn't currently return Onyx updates with a user-friendly error, that's a backend change needed in the ShareBankAccount command.

Additionally, ShareBankAccountParams.emailList is typed as string[] (ShareBankAccountParams.ts:3) while every other emailList parameter in the codebase uses string with an explicit .join(',') call. This works by accident (via Array.toString() during FormData serialization) but should be aligned with the established pattern for consistency.

Investigation details

Evidence chain:

• User taps Share → handleConfirm() at ShareBankAccount.tsx:94-107 extracts emails and calls shareBankAccount()
• shareBankAccount() at BankAccounts.ts:1431-1473 sends API.write(WRITE_COMMANDS.SHARE_BANK_ACCOUNT, ...) with hardcoded failureData error
• The failureData at line 1466 sets errors: getMicroSecondOnyxErrorWithTranslationKey('walletPage.shareBankAccountFailure') which renders as "An unexpected error occurred while trying to share bank account. Please try again."
• ErrorMessageRow at ShareBankAccount.tsx:213-217 displays whatever is in sharedBankAccountData?.errors

emailList type inconsistency:

• ShareBankAccountParams.emailList: string[] (the only one typed this way)
• DeleteMembersFromWorkspaceParams.emailList: string with .join(',')
• OpenReportParams.emailList: string with .join(',')
• Policy.ts:3672, Member.ts:620, Report.ts:1378,1817: all use .join(',') explicitly

Related issue: #87502 describes the same error when sharing with unvalidated accounts, with a more detailed reproduction. That issue specifically calls out that the backend should block sharing to unvalidated accounts with a descriptive error, not a generic one.

---

Possibly related issue: #87502 — same share bank account error flow, specifically for unvalidated accounts.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)