[$250] BA - BA not added in invoices page, PBA flow is triggered instead of VBA

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.59-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87152
Email or phone of affected tester (no customers): kiatest.78+ck414264@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 16/iOS 18.7.1
App Component: Other

Action Performed:

Precondition: User located in US location

1. Launch Hybrid app
2. Create a new account using track intent
3. Go to workspace settings & enable invoices feature
4. Go to the Invoices page of a workspace.
5. Click Add Bank Account
6. Finish Plaid flow using Regions bank
7. Select the ...0000 account and click Next
8. Click the back button and select the ...1111 account
9. Continue adding required details
10. Observe Personal bank account animation is displayed
11. Click Continue or back button & observe user lands on Add BA page with Plaid and Connect manually options
12. Go back to invoice page & observe no bank account is added

Expected Result:

On step 7 & 8 - VBA flow should be triggered instead of PBA flow so user able to add BA successfully in invoices page

Actual Result:

On step 8 - DOB, SSN steps are missed in personal info step & also company info steps are not displayed. PBA flow get triggered instead of VBA while adding BA in invoices page

Note: Bank account cannot be added from invoices page on first attempt for new accounts. It works as expected only after second attempt

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7129326_1776144010606.Screenrecording_04-14-2026_00-58-38_1.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ikevin127

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022044060844808097438
• Upwork Job ID: 2044060844808097438
• Last Price Increase: 2026-04-14

[MelvinBot]

Proposal

What is the root cause of that problem?

After account verification on the Invoices page, WorkspaceInvoicesVerifyAccountPage.tsx:14 navigates to ROUTES.SETTINGS_ADD_BANK_ACCOUNT, which is the Personal Bank Account (PBA) flow (settings/wallet/add-bank-account). Since invoices require a Verified Business Account (VBA), this is the wrong destination. The PBA flow skips the DOB, SSN, and company info steps that the VBA flow requires, which is why the bank account ultimately fails to be added.

What changes do you think we should make in order to solve the problem?

Change navigateForwardTo in WorkspaceInvoicesVerifyAccountPage.tsx to use ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute({policyID: route.params.policyID, backTo: workspaceInvoicePath}) instead of ROUTES.SETTINGS_ADD_BANK_ACCOUNT.getRoute(workspaceInvoicePath). This routes the user into the VBA flow (which includes all required business verification steps) after account verification succeeds.

Investigation details

Flow traced:

1. User clicks "Add Bank Account" in WorkspaceInvoiceVBASection.tsx → calls navigateToBankAccountRoute which correctly targets the VBA route (BANK_ACCOUNT_WITH_STEP_TO_OPEN)
2. If the user is unverified, they get redirected to WORKSPACE_INVOICES_VERIFY_ACCOUNT for KYC
3. After verification succeeds, WorkspaceInvoicesVerifyAccountPage navigates forward — but to the PBA route instead of back to the VBA route

The VBA route (bank-account/:stepToOpen?) accepts policyID and backTo parameters via ROUTES.ts:422-439, and navigateToBankAccountRoute in navigation.ts demonstrates the correct usage pattern.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022044060844808097438

[trasnake87]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an unvalidated user on the workspace Invoices page taps "Add Bank Account", the app routes them through a verification detour that, upon success, lands them in the Personal Bank Account (PBA) flow. The Verified Business Account (VBA) steps (DOB, SSN, company info) are therefore skipped and the bank account cannot be attached to invoices.

What is the root cause of that problem?

The branch in src/pages/settings/Wallet/PaymentMethodList.tsx#L513-L524 intercepts unvalidated users on the Workspaces list path and redirects to ROUTES.WORKSPACE_INVOICES_VERIFY_ACCOUNT. That dedicated screen continues into the PBA route. The non-invoices branch (DYNAMIC_ROUTES.ADD_BANK_ACCOUNT_VERIFY_ACCOUNT) already handles validation inside the VBA flow correctly — the invoice-specific branch is what diverts users into PBA.

What changes do you think we should make in order to solve the problem?

Drop the invoice-specific verify detour in onPressItem and simply call onAddBankAccountPress(). navigateToBankAccountRoute (called from WorkspaceInvoiceVBASection.onAddBankAccountPress) enters the VBA setup flow which natively surfaces the validate-code step together with the DOB/SSN/company-info steps, so no separate PBA-bound screen is needed.

const onPressItem = useCallback(() => {
    if (!isUserValidated && !shouldSkipDefaultAccountValidation) {
        const path = Navigation.getActiveRoute();
        if (!path.includes(ROUTES.WORKSPACES_LIST.route) || !policyID) {
            Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.ADD_BANK_ACCOUNT_VERIFY_ACCOUNT.path));
            return;
        }
        // Fall through to the VBA flow which handles validation + business steps itself
    }
    onAddBankAccountPress();
}, [isUserValidated, onAddBankAccountPress, policyID, shouldSkipDefaultAccountValidation]);

This keeps the fix confined to a single UI component and avoids touching the WorkspaceInvoicesVerifyAccountPage/ROUTES wiring.

[trasnake87]

Contributor details
Your Expensify account email: trasnake87@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010f770315ab181656

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[KJ21-ENG]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After verifying account from the Workspace Invoices flow, users should continue in the workspace bank-account (BA) flow, but the app redirects them into the personal bank-account (PBA) add flow.

What is the root cause of that problem?

WorkspaceInvoicesVerifyAccountPage sends users to ROUTES.SETTINGS_ADD_BANK_ACCOUNT after verification.

App/src/pages/workspace/invoices/WorkspaceInvoicesVerifyAccountPage.tsx

Lines 8 to 15 in 1d43910

	type WorkspaceInvoicesVerifyAccountPageProps = PlatformStackScreenProps<WorkspaceSplitNavigatorParamList, typeof SCREENS.WORKSPACE.INVOICES_VERIFY_ACCOUNT>;
	function WorkspaceInvoicesVerifyAccountPage({route}: WorkspaceInvoicesVerifyAccountPageProps) {
	const workspaceInvoicePath = ROUTES.WORKSPACE_INVOICES.getRoute(route.params.policyID);
	return (
	<VerifyAccountPageBase
	navigateBackTo={workspaceInvoicePath}
	navigateForwardTo={ROUTES.SETTINGS_ADD_BANK_ACCOUNT.getRoute(workspaceInvoicePath)}
	/>

SETTINGS_ADD_BANK_ACCOUNT is the personal settings route (settings/wallet/add-bank-account), so this navigation path drops workspace-context routing and enters PBA.

App/src/ROUTES.ts

Lines 424 to 427 in 1d43910

	SETTINGS_ADD_BANK_ACCOUNT: {
	route: 'settings/wallet/add-bank-account',
	// eslint-disable-next-line no-restricted-syntax -- Legacy route generation

The workspace-aware BA route already exists in BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(...), which can emit workspace/:policyID/bank-account/:stepToOpen when workspaceInvoicePath is true.

App/src/ROUTES.ts

Lines 231 to 259 in 1d43910

	BANK_ACCOUNT_WITH_STEP_TO_OPEN: {
	route: 'bank-account/:stepToOpen?',
	getRoute: ({
	policyID,
	stepToOpen = '',
	bankAccountID,
	backTo,
	subStepToOpen,
	}: {
	policyID: string | undefined;
	stepToOpen?: ReimbursementAccountStepToOpen;
	bankAccountID?: number;
	backTo?: string;
	subStepToOpen?: typeof CONST.BANK_ACCOUNT.STEP.COUNTRY;
	}) => {
	if (!policyID && !bankAccountID) {
	// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
	return getUrlWithBackToParam(`bank-account/${stepToOpen}`, backTo);
	}
	if (bankAccountID) {
	// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
	return getUrlWithBackToParam(`bank-account/${stepToOpen}?bankAccountID=${bankAccountID}`, backTo);
	}
	// TODO this backTo comes from drilling it through bank account form screens
	// should be removed once https://github.com/Expensify/App/pull/72219 is resolved
	// eslint-disable-next-line no-restricted-syntax -- Legacy route generation
	return getUrlWithBackToParam(`bank-account/${stepToOpen}?policyID=${policyID}${subStepToOpen ? `&subStep=${subStepToOpen}` : ''}`, backTo);
	},

What changes do you think we should make in order to solve the problem?

1. In WorkspaceInvoicesVerifyAccountPage, replace the post-verify redirect from ROUTES.SETTINGS_ADD_BANK_ACCOUNT.getRoute(...) to the workspace-aware ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(...) path.
2. Pass policyID and workspaceInvoicePath: true so navigation resolves to workspace/:policyID/bank-account/... instead of personal settings.
3. Keep the same backTo behavior to return users to Workspace Invoices after BA setup.
4. Add regression coverage for: Workspace Invoices -> Verify account -> continue BA flow -> user remains in workspace bank-account route (never enters personal add-bank-account route).

What alternative solutions did you explore? (Optional)

A route alias from SETTINGS_ADD_BANK_ACCOUNT into workspace BA could also work, but that would blur personal/workspace responsibilities. Updating this callsite to use the existing workspace-aware route is safer and clearer.