OldDot shows Expensify Card copy instead of "Central Invoicing"

[blimpich]

In NewDot we are changing the copy of our Travel Invoicing expenses to show "Central invoicing" instead of the typical "Expensify Card – 1234" copy. But we also have to do this in OldDot.

One example of this:

We should do an audit of OldDot to see where we show "Exensify Card - last4Digits" and make sure that we replace that with "Central invoicing" so we are consistent between OldDot and NewDot.

Issue Owner

Current Issue Owner: @allgandalf

[blimpich]

@allgandalf @ishpaul777 either of you want to pick this up?

[allgandalf]

Will pick this up

[blimpich]

Thank you!!

[allgandalf]

did an audit of OldDot for this one, sharing findings so we can align on scope before a PR goes up!

what ND does (for reference)

ND gates "Central invoicing" on card.nameValuePairs.feedCountry === 'TRAVEL_US' via CardUtils.isTravelCard(). three functions check it and return the translated string:

• getCardDescription()
• getCardDescriptionForSearchTable()
• getCompanyCardDescription()

introduced in 1b79b95 and 8afed52.

what OldDot already has

the helpers are already there, just unused for display:

• PHP: Card::isTravelInvoicingCard()
• JS: Card.prototype.isTravelInvoicingCard()
• constant Card::PROGRAM_TRAVEL_US = 'TRAVEL_US' on both sides

so the check is free, we just need to wire it into the render surfaces.

surfaces that need the swap

Web-Expensify (JS):

1. CardUtils.getUserDefinedName() is the closest thing to a choke point, wrap with the travel card check
2. cardItemInfoRow.jsx card settings UI, has the card object
3. expensesChartsView.jsx + expensesView.jsx expense filters rendering card names

Web-Expensify (PHP):

4. SpotnanaAPI::getPaymentMethod() the Spotnana receipt already includes an externalId with the travel_card_{cardID} prefix that Auth sets only when feedCountry === 'TRAVEL_US' (see here) so the gating is effectively the same as ND

Mobile-Expensify:

5. CardController.js card list, has the full card object

proposed approach (mirror ND)

1. add a PHP helper CardUtils::getCardDescription(Card \$card) that returns 'Central invoicing' if isTravelInvoicingCard(), else normal card name. single choke point
2. add a JS helper CardUtils.getCardDescription(card) same thing, then update the react call sites to use it
3. update SpotnanaAPI::getPaymentMethod() to check the externalId for the travel_card_ prefix
4. Mobile: use card.isTravelInvoicingCard() check in CardController.js
5. no backend cardName mutations, display layer only

lmk if this scope looks right or if i should narrow it down for a smaller first PR!

[blimpich]

Looks good to me 👍

[allgandalf]

Opened PR's for review

[allgandalf]

held for https://github.com/Expensify/Auth/pull/21127