Reports - group-by, view and limit do not appear as applied filters

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.60-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86297
Email or phone of affected tester (no customers): soidnjsoidjoisjdiosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Reports > Expenses.
3. Click Display.
4. Apply any group-by and Limit results filter.
5. Click Save.

Expected Result:

group-by, view and limit will appear as applied filters.

Actual Result:

group-by, view and limit do not appear as applied filters.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7131050_1776311807477.1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86297

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86297 - "[Wiring the UI] Revamp search page actions bar" by @bernhardoj (High confidence)
Related Issues: None

Recommendation: REVERT

The causing PR is clearly identified, it is a new feature not yet in production, and the issue is a direct result of its implementation. Reverting is the cleanest path.

Assigned: @bernhardoj (PR author), @aimane-chnaif @JS00001 @luacmartins (approving reviewers)
Labels: DeployBlockerCash kept (Frontend bug from App PR). DeployBlocker not present, no change.

Detailed Analysis

Evidence

• PR [Wiring the UI] Revamp search page actions bar #86297 revamped the search page actions bar, specifically moving Group by, View, and Limit from the filters bar into a new "Display" dropdown button.
• The PR description item 7 explicitly states: "Remove Group by, View, Limit, and Save search button from the filters page."
• As part of this, the constants GROUP_BY, VIEW, and LIMIT were added to a SKIPPED_FILTERS set in useSearchFiltersBar.tsx (line 54) to prevent them from rendering as filter chips in the filters bar.
• However, these three keys were never added to FILTER_LABEL_MAP in SearchUIUtils.ts (lines 4748-4777), which is used by mapFiltersFormToLabelValueList to determine what label to display.
• The Save Search page (SearchSavePage.tsx, line 108) calls mapFiltersFormToLabelValueList without SKIPPED_FILTERS specifically so that all applied filters (including Group by, View, Limit) are shown — but since GROUP_BY, VIEW, and LIMIT have no entry in FILTER_LABEL_MAP, the condition on line 5023 (if (label && value ...)) fails silently and they are never added to the appliedFilters list.

Verification

• Affected file: src/libs/SearchUIUtils.ts (FILTER_LABEL_MAP, lines 4748-4777) — confirmed GROUP_BY, VIEW, LIMIT are absent.
• Affected file: src/pages/Search/SearchSavePage.tsx (line 108) — confirmed the call to mapFiltersFormToLabelValueList passes undefined for skipFilters, intending to show all filters including display options.
• Affected file: src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx (line 54) — confirmed SKIPPED_FILTERS contains GROUP_BY, GROUP_CURRENCY, LIMIT, TYPE, VIEW.
• PR [Wiring the UI] Revamp search page actions bar #86297 modified all three of these files and is confirmed as the source of the regression.
• Bug is staging-only (new feature not in production).

Root Cause

FILTER_LABEL_MAP in SearchUIUtils.ts was not updated to include translation keys for GROUP_BY, VIEW, and LIMIT when PR #86297 moved those options from the filters bar to the Display dropdown. The mapFiltersFormToLabelValueList function relies on FILTER_LABEL_MAP to produce display labels; without entries for these three keys, they are silently excluded from the applied filters list shown on the Save Search page, even though they are semantically part of the saved search query.