Expensify Card - Card feed selector does not show Expensify Card icon

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.60-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86848
Email or phone of affected tester (no customers): applausetester+sjois22jd3@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Create workspace A and workspace B.
• Both workspaces are set up with Expensify Card feature.

1. Go to staging.new.expensify.com
2. Go to workspace A settings > Expensify Card.

Expected Result:

Card feed selector will show Expensify Card icon (similar to company card feed).

Actual Result:

Card feed selector does not show Expensify Card icon.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @koko57

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86848

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86848 - "Release 3: UI Updates for Expensify Cards" by @narefyev91 (High confidence)
Related Issues: #81452

Recommendation: REVERT

PR #86848 introduced a regression where the Expensify Card icon is no longer displayed in the card feed selector, and the fix requires reverting the App PR.

Assigned: @narefyev91 (PR author), @linhvovan29546 (approving reviewer), @madmax330 (approving reviewer)
Labels: DeployBlockerCash kept (Frontend bug — App PR is the cause); no label changes made.

Detailed Analysis

Evidence

• The issue reports that the card feed selector does not show the Expensify Card icon in workspace A settings > Expensify Card.
• melvin-bot already flagged PR Release 3: UI Updates for Expensify Cards #86848 as the causing PR.
• PR Release 3: UI Updates for Expensify Cards #86848 merged on 2026-04-14, and this issue is staging-only (version 9.3.60-0), placing it squarely within the staging deploy window for that PR.
• PR Release 3: UI Updates for Expensify Cards #86848 deleted WorkspaceExpensifyCardSelectorPage.tsx and replaced it with a new WorkspaceExpensifyCardFeedSelectorPage.tsx, while also reworking WorkspaceExpensifyCardListPage.tsx.

Verification

• Affected file: src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx
• PR Release 3: UI Updates for Expensify Cards #86848 directly modifies this file (confirmed via gh pr view 86848 --json files).

Root Cause

In WorkspaceExpensifyCardListPage.tsx line 95 (introduced by this PR):

const cardFeedIcon = useMemo(() => <CardFeedIcon selectedFeed={undefined} />, []);

The CardFeedIcon component (src/components/CardFeedIcon.tsx) has this logic:

1. If isExpensifyCardFeed === true renders ExpensifyCardFeedIcon with the card image (correct path)
2. If isPlaidCardFeed renders PlaidCardFeedIcon
3. If !selectedFeed returns null (this is what happens here)

Since selectedFeed is undefined and isExpensifyCardFeed is not passed (defaults to false), the component returns null — meaning no icon is rendered in the feed selector header. The old WorkspaceExpensifyCardSelectorPage.tsx (deleted by this PR) rendered the icon directly using illustrations.ExpensifyCardImage inside each list item, bypassing this issue entirely.

The fix would be to pass isExpensifyCardFeed={true} to the <CardFeedIcon> call in WorkspaceExpensifyCardListPage.tsx, or to revert the entire PR.