Expensify Card - Issue card flow does not restart after changing card feed

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.60-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86848
Email or phone of affected tester (no customers): applausetester+sjois22jd3@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Create workspace A and workspace B.
• Both workspaces are set up with Expensify Card feature.
• Invite User C to workspace A.

1. Go to staging.new.expensify.com
2. Go to workspace A settings > Expensify Card.
3. Click Issue card.
4. Select User C and reach confirm page.
5. Click outside RHP to close issue card flow.
6. Click Card feed dropdown.
7. Select workspace B.
8. Click Issue card > Confirm > enter magic code if needed.
9. Go to workspace B settings > Members.

Expected Result:

In Step 7, issue card flow should restart after changing card feed from a different workspace.

Actual Result:

In Step 7, issue card flow resumes after changing card feed from a different workspace.
In Step 8, User C is auto invited to workspace B because issue card flow resumes from workspace A.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86848

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86848 - "Release 3: UI Updates for Expensify Cards" by @narefyev91 (High confidence)
Related Issues: #81452

Recommendation: REVERT

PR 86848 introduced a new WorkspaceExpensifyCardFeedSelectorPage and changed WorkspaceExpensifyCardListPage so that clearIssueNewCardFormData() is not called in all abandonment paths. When the user dismisses the RHP mid-flow (step 5 in the repro), the issue card form data (policyID, step, assignee) is left in Onyx. When they then switch to workspace B via the feed selector dropdown and press Issue card, the flow resumes from the stale workspace A state instead of restarting, which causes User C to be silently invited to workspace B. The fix requires reverting or patching the App PR.

Assigned: @narefyev91 (PR author), @linhvovan29546 (approving reviewer), @madmax330 (approving reviewer)
Labels: DeployBlockerCash kept (Frontend bug in App PR). DeployBlocker not present, no change needed.

Evidence:

• The melvin-bot already identified PR 86848 as the causal PR (referenced in the issue body and first bot comment).
• PR 86848 was merged on 2026-04-14, and the issue was reported on 2026-04-16 against version 9.3.60-0, matching this staging release.
• The PR deleted WorkspaceExpensifyCardSelectorPage and replaced it with WorkspaceExpensifyCardFeedSelectorPage. The new page has an Issue card button (handleAddCardPress) that calls setIssueNewCardStepAndData and navigates to the issue card flow.
• In WorkspaceExpensifyCardListPage, the feed selector dropdown navigates to WORKSPACE_EXPENSIFY_CARD_SELECT_FEED. When the user opens the issue card flow from workspace A, partially completes it, dismisses the RHP without finishing, then selects workspace B from the feed dropdown, clearIssueNewCardFormData is never called. The stale issueNewCard Onyx data still holds the policyID, step, and assignee of workspace A.
• When the user then presses Issue card from WorkspaceExpensifyCardFeedSelectorPage for workspace B, setIssueNewCardStepAndData is called with the new policyID but pre-existing step and assignee data from workspace A persists, causing the flow to resume mid-way with workspace A assignee (User C), resulting in User C being invited to workspace B.
• The PR also changed shouldShowSelector from strictly-greater-than 1 to greater-than-or-equal 1, making the feed selector appear even with a single feed.

Verification:

• Affected files: src/pages/workspace/expensifyCard/WorkspaceExpensifyCardFeedSelectorPage.tsx (new file introduced by PR 86848), src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx (modified by PR 86848).
• The bug is staging-only (new feature, not in production), as stated in the issue.

Root Cause:
The missing clearIssueNewCardFormData() call is in the workspace-switching path: user opens the issue card flow from workspace A, abandons it by closing the RHP, then navigates to workspace B via the feed dropdown and presses Issue card. The Onyx key for ISSUE_NEW_EXPENSIFY_CARD_FORM retains the previous step and assignee data, so the flow resumes rather than restarting cleanly.

[MelvinBot]

Proposal

What is the root cause of that problem?

The "Issue new card" flow state is stored per-policyID in Onyx at RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD_{policyID}. When a user starts the issue card flow, selects an assignee, then closes the RHP without completing the flow, the state (including assigneeEmail) is never cleared.

When the user then switches the card feed dropdown to a different workspace's feed and clicks "Issue card" again, the entry points — handleAddCardPress and handleIssueCardPress — only call clearIssueNewCardFormData() (which clears ONYXKEYS.FORMS.ISSUE_NEW_EXPENSIFY_CARD_FORM) but not clearIssueNewCardFlow(policyID) (which would clear the flow state at RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD_{policyID}).

Because setIssueNewCardStepAndData uses Onyx.merge, old data fields like assigneeEmail from the previous incomplete flow survive into the new flow, causing the stale assignee to be carried over and auto-invited to the wrong workspace.

What changes do you think we should make in order to solve the problem?

Call clearIssueNewCardFlow(policyID) at the beginning of both handleAddCardPress (in WorkspaceExpensifyCardFeedSelectorPage.tsx) and handleIssueCardPress (in WorkspaceExpensifyCardListPage.tsx), before calling setIssueNewCardStepAndData. This ensures any stale flow state from a previously abandoned issue card flow is fully reset before starting a new one.

What alternative solutions did you explore? (Optional)

1. Clear on feed switch — call clearIssueNewCardFlow inside selectFeed/selectOtherFeed. This works but is less targeted; the real invariant is "starting a new flow should start clean."
2. Clear on RHP dismissal — add cleanup when the RHP is closed without completing the flow. This is harder to implement reliably across all dismissal paths (back gesture, clicking outside, hardware back button) and is unnecessary if the flow entry points properly reset state.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.