Scan - "Enter a merchant name" not show after manually edit the amount field and select category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.60-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-19602/folder/13176933/41237714/1336301980
Email or phone of affected tester (no customers): lekima20+65104@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

1. Open https://staging.new.expensify.com
2. Navigate to any workspace chat
3. Create a scan expense with a picture and not set Category
4. While the receipt scanning click on this expense
5. Manually edit the amount field
6. Select a category

Expected Result:

Verify the merchant field shows a error to "Enter a merchant name"

Actual Result:

After edited amount, "Enter a merchant name" briefly displays and quickly disappeared. (It will appears in report after some minutes)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7131174_1776322610656.Recording__1973.mp4

View all open jobs on GitHub

[samranahm]

Proposal

What is the root cause of that problem?

In ReportActionItemCreated.tsx, there is explicit logic that reverses the avatar order when the current user is the invoice receiver:

sort: isInvoiceRoom(report) && isCurrentUserInvoiceReceiver(report) ? CONST.REPORT_ACTION_AVATARS.SORT_BY.REVERSE : undefined

The avatar order for invoice rooms should be consistent regardless of viewer: workspace on left, receiver on right.

What changes do you think we should make in order to solve the problem?

We should remove the sort property from the horizontalStacking prop passed to ReportActionAvatars in ReportActionItemCreated.tsx. This will eliminates the reversal, so the icon array from getIconsForPolicyRoom() is used as-is "workspace avatar left, receiver avatar right".

here

App/src/pages/inbox/report/ReportActionItemCreated.tsx

Lines 69 to 77 in 4cc4dcf

	<ReportActionAvatars
	reportID={reportID}
	size={CONST.AVATAR_SIZE.X_LARGE}
	horizontalStacking={{
	displayInRows: shouldUseNarrowLayout,
	maxAvatarsInRow: shouldUseNarrowLayout ? CONST.AVATAR_ROW_SIZE.DEFAULT : CONST.AVATAR_ROW_SIZE.LARGE_SCREEN,
	overlapDivider: 4,
	sort: isInvoiceRoom(report) && isCurrentUserInvoiceReceiver(report) ? CONST.REPORT_ACTION_AVATARS.SORT_BY.REVERSE : undefined,
	}}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.