Expensify Card - Issue card button is unresponsive when attempting to issue a second card

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.60-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-19603/folder/13176890/41237378/1336302888
Email or phone of affected tester (no customers): applausetester+bm8737ks@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: android
App Component: Workspace Settings

Action Performed:

Preconditions:
BA setup in the Workspace and the Expensify card enabled

1. Go to staging.new.expensify.com
2. Go to the Expensify Card page
3. Issue a virtual Expensify Card for yourself
4. Click the Issue card button again to issue another card

Expected Result:

Issue card button should be responsive and allow issuing a second card

Actual Result:

Issue card button is unresponsive on the second attempt

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7131364_1776342831228.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary: Frontend bug. Primary causing PR: #87254 (medium confidence). Secondary candidate: #86848 (low-medium confidence). Recommendation: REVERT PR 87254 first. Assigned: @JKobrynski @fabioh8010 @Krishna2323 @roryabraham @narefyev91 @linhvovan29546 @madmax330. Labels: DeployBlockerCash kept (App PR involved).

[OSBotify]

Detailed analysis follows.

Classification: Frontend bug
Causing PR: #87254 by @JKobrynski (Medium confidence)
Secondary candidate: #86848 by @narefyev91 (Low-Medium confidence)
Recommendation: REVERT PR 87254 first.

Primary suspect - PR 87254

This PR migrated ONYXKEYS.COLLECTION.ISSUE_NEW_EXPENSIFY_CARD to ONYXKEYS.COLLECTION.RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD and registered it in the ramOnlyKeys array. The critical change in src/pages/workspace/expensifyCard/issueNew/IssueNewCardPage.tsx removed {initWithStoredValues: false} from the useOnyx call.

Before: useOnyx(...ISSUE_NEW_EXPENSIFY_CARD...policyID, {initWithStoredValues: false})
After: useOnyx(...RAM_ONLY_ISSUE_NEW_EXPENSIFY_CARD...policyID) (option removed)

The {initWithStoredValues: false} option caused the component to always start with undefined as initial state and wait for the server API response from startIssueNewCardFlow. After removal, the component immediately reads whatever value is in the RAM-only store.

The second card issuance likely fails as follows:

1. User issues first card - clearIssueNewCardFlow sets RAM-only key to {currentStep: null, data: {}, isSuccessful: false, isLoading: false}
2. User taps Issue card again - setIssueNewCardStepAndData is called (no step, currentStep stays null), then Navigation.navigate opens IssueNewCardPage
3. If React Navigation keeps the screen cached (common for RHP modals), the useEffect([policyID]) does NOT re-fire since policyID has not changed
4. startIssueNewCardFlow is never called on the second open, leaving the flow in an uninitialized state

Secondary suspect - PR 86848

Changed shouldShowSelector from Object.keys(allExpensifyCardFeeds).length > 1 to allAdminExpensifyCardFeeds.length >= 1. Users with one Expensify Card feed now see the FeedSelector UI, changing the button layout on Android. This would affect the first press too, making it lower-confidence for a second-attempt-only failure.

Assigned: @JKobrynski @fabioh8010 @Krishna2323 @roryabraham (PR 87254), @narefyev91 @linhvovan29546 @madmax330 (PR 86848)
Labels: DeployBlockerCash kept (frontend App PRs involved).