Expense - Error shows up when duplicating non-reimbursable expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.60-17
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84657
Email or phone of affected tester (no customers): jsodijnsdojnodnjsoinjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Set Submissions to Instantly.
• Disable Approvals and Payments.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two non-reimbursable expenses.
4. Retract each report (open report > More > Retract).
5. Go to Reports > Expenses.
6. Bulk select both expenses.
7. Click dropdown button > Duplicate expenses.
8. Go back to workspace chat.
9. Open both new reports.

Expected Result:

Expenses will be duplicated without issue.

Actual Result:

Two reports are created. Each report contains an expense with error.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7133094_1776529879085.1.mp4

View all open jobs on GitHub

[melvin-bot]

@JS00001 recently merged #84657, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #84657 - "[Duplicate Expense] Allow bulk duplication." by @Krishna2323 (High confidence)
Related Issues: #84281

Recommendation: REVERT

PR #84657 introduced the bulk expense duplication feature which is confirmed to be the source of this bug. The issue is reproducible on staging but not production (this is a new feature that does not exist in production), making a clean revert the safest path forward.

Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @JS00001 (approving reviewer) from highest-confidence causing PR only
Labels: DeployBlockerCash is kept (Frontend bug — App PR caused this). DeployBlocker was not present and was not modified.

Detailed Analysis

Evidence

• The issue body directly references PR [Duplicate Expense] Allow bulk duplication.  #84657 as the regression source (https://github.com/Expensify/App/pull/84657).
• The bug is categorized as "Reproducible in staging? Yes" and "Reproducible in production? N/A - new feature, doesn't exist in prod", which confirms this feature was introduced in the current staging cycle.
• PR [Duplicate Expense] Allow bulk duplication.  #84657 is included in the active StagingDeployCash for version 9.3.60-17.
• The reproduction steps closely follow the test steps defined in PR [Duplicate Expense] Allow bulk duplication.  #84657's QA section (bulk duplication via Search > Expenses > bulk select > Duplicate expenses), confirming the regression is in the newly added code path.

Verification

• Affected files: src/libs/actions/IOU/Duplicate.ts, src/hooks/useBulkDuplicateAction.ts, src/components/Search/BulkDuplicateHandler.tsx, src/hooks/useSearchBulkActions.ts
• PR [Duplicate Expense] Allow bulk duplication.  #84657 directly modifies all of these files — this is the PR that created them.
• The bulkDuplicateExpenses function in Duplicate.ts iterates over selected transactions and calls duplicateExpenseTransaction for each, passing the existingIOUReport and shouldDeferAutoSubmit for proper sequencing. The bug occurs with non-reimbursable expenses specifically, which involve distinct nonReimbursableTotal tracking on the expense report.

Root Cause

The bulkDuplicateExpenses function in src/libs/actions/IOU/Duplicate.ts (introduced by this PR) iterates over selected transactions and builds sequential calls to duplicateExpenseTransaction. For non-reimbursable expenses, the nonReimbursableTotal field on the IOU report is computed per-call in getMoneyRequestInformation in IOU/index.ts. When the first duplicate call produces an optimistic IOU report, subsequent iterations receive it via existingIOUReport, but the nonReimbursableTotal arithmetic across iterations may be incorrect because the optimistic IOU report state is not fully reflected in the module-level allReports cache at the time iteration 2 runs (the comment in the code at line 998-1001 of Duplicate.ts even acknowledges this deferred-state race). This leads to inconsistent report state that the server rejects, surfacing as an error on the duplicated expense. The preconditions (Submissions set to Instantly, Approvals and Payments disabled) likely cause the report to be submitted immediately, exposing the corrupted optimistic state on receipt.